Show via pretty + tweaks
#142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This potentially saves some work (and some gas!) if not all arguments are used in the format string.
emilypi
reviewed
Jun 6, 2024
| @@ -96,7 +96,7 @@ round: 50 | |||
| scalar-mult: 360225 | |||
| select: 100383581 | |||
| shift: 4 | |||
| show: 101 | |||
| show: 4002 | |||
| showPactValue info pv = do | ||
| sz <- sizeOf SizeOfV0 pv | ||
| chargeGasArgs info $ GConcat $ TextConcat $ GasTextLength $ fromIntegral sz | ||
| pure $ Pretty.renderCompactText pv |
There was a problem hiding this comment.
Small bikesheddey nitpick: if i'm calling showPactValue, i don't assume any rendering or compaction: I assume it's using the show instance on pact values. Maybe we keep renderPactValue as a name, because it implies there's work being done on the value to produce text.
There was a problem hiding this comment.
Good point, I agree the current name is slightly misleading.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist:
Additionally, please justify why you should or should not do the following: