Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise LSP hover details to produce new documentation #157

Merged
merged 8 commits into from
Jul 10, 2024
Merged

Revise LSP hover details to produce new documentation #157

merged 8 commits into from
Jul 10, 2024

Conversation

rsoeldner
Copy link
Member

This PR will re-work the way we provide the hover information\ builtin documentation.

PR checklist:

  • Test coverage for the proposed changes
  • PR description contains example output from repl interaction or a snippet from unit test output
  • Any changes that could be relevant to users have been recorded in the changelog

Additionally, please justify why you should or should not do the following:

  • Confirm replay/back compat
  • Benchmark regressions
  • (For Kadena engineers) Run integration-tests against a Chainweb built with this version of Pact

@rsoeldner rsoeldner marked this pull request as ready for review July 9, 2024 07:39
@rsoeldner
output new markdown docs
6f1e463 
Signed-off-by: rsoeldner <r.soeldner@gmail.com>
@jmcardon jmcardon merged commit 5d76b93 into master Jul 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmcardon jmcardon jmcardon approved these changes

@jwiegley jwiegley Awaiting requested review from jwiegley jwiegley is a code owner

@emilypi emilypi Awaiting requested review from emilypi emilypi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rsoeldner @jmcardon