Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all orphan instances #186

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Remove all orphan instances #186

merged 1 commit into from
Jul 22, 2024

Conversation

jmcardon
Copy link
Member

@jmcardon jmcardon commented Jul 19, 2024

This PR now removes all orphan instances replaced with newtypes

Blocked on #185

PR checklist:

  • Test coverage for the proposed changes
  • PR description contains example output from repl interaction or a snippet from unit test output
  • (If Relevant) Documentation has been (manually) updated at https://docs.kadena.io/pact

Additionally, please justify why you should or should not do the following:

  • Benchmark regressions
  • Confirm replay/back compat (Ignore until core release)
  • (For Kadena engineers) Run integration-tests against a Chainweb built with this version of Pact (Ignore until core release)

@jmcardon jmcardon merged commit 98558ed into master Jul 22, 2024
3 checks passed
@jmcardon jmcardon deleted the jose/kill-orphans branch July 22, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants