Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use PactValue for data field #188

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Use PactValue for data field #188

merged 1 commit into from
Jul 23, 2024

Conversation

edmundnoble
Copy link
Collaborator

PR checklist:

  • Test coverage for the proposed changes
  • PR description contains example output from repl interaction or a snippet from unit test output
  • (If Relevant) Documentation has been (manually) updated at https://docs.kadena.io/pact

Additionally, please justify why you should or should not do the following:

  • Benchmark regressions
  • Confirm replay/back compat (Ignore until core release)
  • (For Kadena engineers) Run integration-tests against a Chainweb built with this version of Pact (Ignore until core release)

@edmundnoble edmundnoble force-pushed the push-pxkqyytxyusu branch 2 times, most recently from 6ebe88f to f7f3db4 Compare July 19, 2024 16:39
rsoeldner
rsoeldner previously approved these changes Jul 19, 2024
View reviewed changes
rsoeldner
rsoeldner reviewed Jul 19, 2024
View reviewed changes
Copy link
Member

@rsoeldner rsoeldner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accidentally approved

@rsoeldner rsoeldner dismissed their stale review July 19, 2024 17:00

roeldner

@jmcardon jmcardon force-pushed the push-pxkqyytxyusu branch from 41caaf5 to 5a113fe Compare July 22, 2024 21:00
@edmundnoble edmundnoble merged commit 875a787 into master Jul 23, 2024
3 checks passed
@edmundnoble edmundnoble deleted the push-pxkqyytxyusu branch July 23, 2024 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsoeldner rsoeldner rsoeldner left review comments

@jmcardon jmcardon jmcardon approved these changes

@jwiegley jwiegley Awaiting requested review from jwiegley

@emilypi emilypi Awaiting requested review from emilypi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edmundnoble @jmcardon @rsoeldner