Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amend NoTxInCommit error to more general NotInTx error #198

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

edmundnoble
Copy link
Collaborator

PR checklist:

  • Test coverage for the proposed changes
  • PR description contains example output from repl interaction or a snippet from unit test output
  • (If Relevant) Documentation has been (manually) updated at https://docs.kadena.io/pact

Additionally, please justify why you should or should not do the following:

  • Benchmark regressions
  • Confirm replay/back compat (Ignore until core release)
  • (For Kadena engineers) Run integration-tests against a Chainweb built with this version of Pact (Ignore until core release)

@@ -183,7 +183,7 @@ mockPactDb serial = do
writeIORef ptTxLogQueue txl
pure logs
Nothing ->
throwIO Errors.NoTxToCommit
throwIO (Errors.NotInTx "commit")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whats the reson for this change? Seems like we are only using it with commit?

Co-authored-by: rsoeldner <r.soeldner@gmail.com>
@jmcardon jmcardon merged commit 1c0daee into master Aug 8, 2024
12 checks passed
@jmcardon jmcardon deleted the push-qkoouoropttn branch August 8, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants