-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supporting Subdirectory as ROOT_URL? #315
Comments
What I suggest it to create a Group route. Create is based on the So, locally you can run it with "/" and when deploying you can set it to whatever you want. |
Got it. I'll use group prefix instead of changing the way url gets resolved. Thanks! |
Awesome.. Hope we can close this. |
Hum, I also encounter this problem in Wekan (cf. wekan/wekan#133) with the difference that I'm not fully controlling the production environment in case people are self-hosting the application. From meteor/meteor#2067, it seems to me that flow-router should handle this subdirectory parameter exposed by Meteor. |
Hmm. Good idea. Here's the place to add it: https://github.com/kadirahq/flow-router/blob/master/client/router.js#L367 |
I'm deploying two apps on the same server/base domain, using nginx to handle the proxy to subdirectories. e.g. http://mydomain.com/appOne and http://mydomain.com/appTwo.
But I think when FR resolves the url, the subdirectories of ROOT_URL are stripped off. So if I want a route "http://mydomain.com/appOne/login" with ROOT_URL="http://mydomain.com/appOne", I still need to config route "/appOne/login" instead of "/login".
The issue originally comes from the npm "url" package. But would FR be supporting subdirectory in the future, or we should stick with the above work-arounds for this?
The text was updated successfully, but these errors were encountered: