-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No FlowRouter.url()
function
#373
Comments
Okay. There was no reason not to include that. Yeah go for it.
|
@johanbrook are you still on this? I added this functionality + tests before I read this issue. I don't want to step on your toes :) |
@jreinert Cool, great! No worries at all – my own fault for being busy the last two days ;) File a PR and we're done 👍 |
PR already submitted. |
While migrating from Iron Router, I discovered that there is not
FlowRouter.url()
function, which in contrast toFlowRouter.path()
returns the absolute URL, and not just the path. Currently, we have to resort to an in-app helper. Personally, I think this is something a router should take care of.Is this a deliberate decision? If not, I'd be happy to provide PR + tests.
Thanks!
The text was updated successfully, but these errors were encountered: