Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No FlowRouter.url() function #373

Closed
johanbrook opened this issue Oct 28, 2015 · 4 comments · Fixed by #374
Closed

No FlowRouter.url() function #373

johanbrook opened this issue Oct 28, 2015 · 4 comments · Fixed by #374

Comments

@johanbrook
Copy link
Contributor

While migrating from Iron Router, I discovered that there is not FlowRouter.url() function, which in contrast to FlowRouter.path() returns the absolute URL, and not just the path. Currently, we have to resort to an in-app helper. Personally, I think this is something a router should take care of.

Is this a deliberate decision? If not, I'd be happy to provide PR + tests.

Thanks!

@arunoda
Copy link
Contributor

arunoda commented Oct 28, 2015

Okay. There was no reason not to include that. Yeah go for it.
On 2015 ඔක් 28, බදාදා at ප.ව. 3.33 Johan Brook notifications@github.com
wrote:

While migrating from Iron Router, I discovered that there is not
FlowRouter.url() function, which in contrast to FlowRouter.path() returns
the absolute URL, and not just the path. Currently, we have to resort to an
in-app helper. Personally, I think this is something a router should take
care of.

Is this a deliberate decision? If not, I'd be happy to provide PR + tests.

Thanks!


Reply to this email directly or view it on GitHub
#373.

@repomaa
Copy link
Contributor

repomaa commented Oct 30, 2015

@johanbrook are you still on this? I added this functionality + tests before I read this issue. I don't want to step on your toes :)

repomaa pushed a commit to repomaa/flow-router that referenced this issue Oct 30, 2015
@johanbrook
Copy link
Contributor Author

@jreinert Cool, great! No worries at all – my own fault for being busy the last two days ;) File a PR and we're done 👍

@arunoda
Copy link
Contributor

arunoda commented Nov 1, 2015

PR already submitted.

@arunoda arunoda closed this as completed Nov 1, 2015
repomaa pushed a commit to repomaa/flow-router that referenced this issue Nov 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants