Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix triggers loading bug #173

Merged
merged 3 commits into from
Jun 22, 2015
Merged

Fix triggers loading bug #173

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e20af42
fix bug in triggers loading
kelbongoo Jun 21, 2015
9e37052
Update router.js
kelbongoo Jun 21, 2015
0179f2f
added if parenthesis
kelbongoo Jun 21, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions client/router.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,15 +452,15 @@ Router.prototype._initTriggersAPI = function() {
this.triggers = {
enter: function(triggers, filter) {
triggers = Triggers.applyFilters(triggers, filter);
_.extend(self._triggersEnter, triggers);
if(triggers.length) self._triggersEnter = self._triggersEnter.concat(triggers);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to add brackets to if. See: https://github.com/meteorhacks/code-standards/blob/master/docs/style_guide.md#brace-style

},

exit: function(triggers, filter) {
triggers = Triggers.applyFilters(triggers, filter);
_.extend(self._triggersExit, triggers);
if(triggers.length) self._triggersExit = self._triggersExit.concat(triggers);
}
};
};

Router.prototype._page = page;
Router.prototype._qs = qs;
Router.prototype._qs = qs;