Adds name option to groups

[richsilv]

Sometimes it's useful to know which group the current route belongs to (for example, is it only for logged-in users?). Currently, that's not possible unless you're using prefixes for that group.

Allowing the user to pass a name option resolves this as it allows you to use FlowRouter.current().route.group.name to identify the current group.

[arunoda]

Don't increment this.

[richsilv]

Apologies, that was just so I could tell I was using the new version locally.

[arunoda]

One more thing?
Is it possible to have a test case for this?

On 2015 අගෝ 26, බදාදා at ප.ව. 6.30 Richard Silverton <
notifications@github.com> wrote:

Sometimes it's useful to know which group the current route belongs to
(for example, is it only for logged-in users?). Currently, that's not
possible unless you're using prefixes for that group.

Allowing the user to pass a name option resolves this as it allows you to

use FlowRouter.current().route.group.name to identify the current group.

You can view, comment on, or merge this pull request online at:

#290
Commit Summary

• Adds support for group names
• removed browserify files

File Changes

• M client/group.js
  https://github.com/kadirahq/flow-router/pull/290/files#diff-0 (1)
• M package.js
  https://github.com/kadirahq/flow-router/pull/290/files#diff-1 (4)

Patch Links:

• https://github.com/kadirahq/flow-router/pull/290.patch
• https://github.com/kadirahq/flow-router/pull/290.diff

—
Reply to this email directly or view it on GitHub
#290.

[richsilv]

👍

[arunoda]

Awesome.

[serkandurusoy]

I have two quick questions:

1. What happens if groups are nested? Which name would the method return?
2. Does it not make sense to create getGroupName() that depends on _routeClosed so that we can get the name reactively?

[richsilv]

@serkandurusoy

1. name is just a property rather than a method, so you can get the deepest-nested group name with FlowRouter.current().route.group.name, and its parent group's name with FlowRouter.current().route.group.parent.name, and so on.
2. If you want to do something reactive with name, you just need to put FlowRouter.watchPathChange() in your reactive function, and the computation will rerun whenever the current group name changes (or its parent group, etc.).

[serkandurusoy]

Thanks this has been really helpful, especially with an "active route group" helper I can now use in a deeply nested menu and route structure. 👏

[arunoda]

Btw: Shall we add this into the README?
Could you send me a PR to the group section with how to access this.
On 2015 අගෝ 28, සිකු at ප.ව. 3.31 Serkan Durusoy notifications@github.com
wrote:

Thanks this has been really helpful, especially with an "active route
group" helper I can now use in a deeply nested menu and route structure. [image:
👏]

—
Reply to this email directly or view it on GitHub
#290 (comment).