Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support file which named '...' #68

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

howel52
Copy link

@howel52 howel52 commented Jan 6, 2021

... or more then two dots may be a file

but throw Error like RangeError: path should be a path.relative()d string, but got "..." now.

@codecov-io
Copy link

codecov-io commented Jan 6, 2021

Codecov Report

Merging #68 (fdfd710) into master (7cc95d2) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #68   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          129       129           
=========================================
  Hits           129       129           
Impacted Files Coverage Δ
index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cc95d2...fdfd710. Read the comment docs.

@kaelzhang
Copy link
Owner

I'm really not quite sure about the compatibility cross different file systems.

I'm struggling in my head whether I should make the validation as a convention(warning) or not(error)

@howel52
Copy link
Author

howel52 commented Jan 7, 2021

yep, maybe we need another solution to solve this bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants