Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify, refine tmLanguage.json #20

Merged
merged 3 commits into from
Sep 11, 2023
Merged

Conversation

IHIutch
Copy link
Contributor

@IHIutch IHIutch commented Sep 9, 2023

So I've been tinkering with this a bit more. I took a look at the Liquid tmLanguage.json which is really well organized. (And thanks again for help @panoply).

@kaermorchen You may want to take a look at this and see if it can be better organized, you're much more familiar with Twig than me.

But this seems to be working pretty well and is a whole lot simpler than what I came up with before. But I left the PR open because of the twig keywords that I just stuffed into keyword.other.twig.

Let me know what you think.

@kaermorchen
Copy link
Owner

Hi!

I am not familiar with tmLanguage syntax and if you think this is good I will merge the PR. And yeah it looks really better organized and simple, I like it.

Thanks for your help.

@IHIutch
Copy link
Contributor Author

IHIutch commented Sep 11, 2023

Awesome 🚀

@IHIutch IHIutch marked this pull request as ready for review September 11, 2023 14:55
@kaermorchen kaermorchen merged commit 131d2ab into kaermorchen:master Sep 11, 2023
@kaermorchen kaermorchen added the enhancement New feature or request label Sep 11, 2023
@panoply
Copy link

panoply commented Sep 12, 2023

@IHIutch Glad it helped! You might find some useful stuff in the Liquify release of the VSCode extension. I have not had enough time to finish things, but that is where the language server, Liquid parser which does incremental updates and can traverse a couple thousand LoC effortlessly, plus much more (such as the specification approach) - some of that logic might be portable enough into Twig.

I've been considering extending support in Æsthetic for Twig, would love some feedback if I decide to go ahead on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants