Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create connector 404 (#92) #136

Merged
merged 5 commits into from
Mar 7, 2024
Merged

Create connector 404 (#92) #136

merged 5 commits into from
Mar 7, 2024

Conversation

Nilumilak
Copy link
Member

Create Connector button is disabled when connects list is empty

  • Added Tooltip
  • Added tests

fix #92

+ Added Tooltip
+ Added tests
@Nilumilak Nilumilak added scope/frontend Related to frontend changes type/bug Something isn't working status/triage/completed Automatic triage completed labels Feb 12, 2024
@Nilumilak Nilumilak self-assigned this Feb 12, 2024
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress and removed status/triage Issues pending maintainers triage labels Feb 12, 2024
CreateConnectorButton component moved to it's own file
+ removed component CreateConnectorButton.tsx
+ added prop showTooltip to Tooltip component
@Nilumilak Nilumilak requested a review from Mgrdich March 4, 2024 10:27
@Haarolean Haarolean removed the status/triage/manual Manual triage in progress label Mar 7, 2024
@Haarolean Haarolean merged commit 135055c into main Mar 7, 2024
8 of 11 checks passed
@Haarolean Haarolean deleted the bugfix/create_connector branch March 7, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/frontend Related to frontend changes status/triage/completed Automatic triage completed type/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FE: Create connector button throws 404 if KC cluster is inaccessible
3 participants