Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BE: Chore: Cleanup api tests #698

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Conversation

wernerdv
Copy link
Contributor

@wernerdv wernerdv commented Dec 9, 2024

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
A small cleanup in the api module tests.
Fixed IDEA warnings, removed unused imports, etc.

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@wernerdv wernerdv requested a review from a team as a code owner December 9, 2024 19:44
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Dec 9, 2024
@wernerdv
Copy link
Contributor Author

wernerdv commented Dec 9, 2024

@Haarolean please take a look at this small cleanup.

@Haarolean Haarolean added scope/backend Related to backend changes type/chore Boring stuff, could be refactoring or tech debt and removed status/triage/manual Manual triage in progress labels Dec 10, 2024
@Haarolean Haarolean added this to the 1.1 milestone Dec 10, 2024
@Haarolean Haarolean merged commit 318bcc9 into kafbat:main Dec 10, 2024
11 of 13 checks passed
@wernerdv wernerdv deleted the cleanup_api_tests branch December 10, 2024 18:33
K-Diger pushed a commit to K-Diger/kafbat-kafka-ui that referenced this pull request Dec 20, 2024
Co-authored-by: Roman Zabaluev <gpg@haarolean.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/backend Related to backend changes status/triage/completed Automatic triage completed type/chore Boring stuff, could be refactoring or tech debt
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants