Add a validate only flag process to facilitate descriptor testing in feature branches and add ConfigurationKeyValidation and TopicNameRegexValidation validations #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
…lidations in the topology. This would be without access to the cluster, if validations are required with connectivity they would need to use the dry run parameter
purbon
changed the title
purbon
added a commit
that referenced
this pull request
May 3, 2021
…feature branches and add ConfigurationKeyValidation and TopicNameRegexValidation validations (#274) * add a validate option for the CLI, this would allow only to run validations in the topology. This would be without access to the cluster, if validations are required with the connectivity they would need to use the dry run parameter * add validation for config keys in topics * Add a TopicNameRegexValidation to validate topic names * simplify the code by making the validation a topic one and add test for this module * make the config value a constant for the topic name regexp * docs update Co-authored-by: Leonardo Bonacci <aabcehmu@mailfence.com>
purbon
added a commit
that referenced
this pull request
May 3, 2021
…feature branches and add ConfigurationKeyValidation and TopicNameRegexValidation validations (#274) * add a validate option for the CLI, this would allow only to run validations in the topology. This would be without access to the cluster, if validations are required with the connectivity they would need to use the dry run parameter * add validation for config keys in topics * Add a TopicNameRegexValidation to validate topic names * simplify the code by making the validation a topic one and add test for this module * make the config value a constant for the topic name regexp * docs update Co-authored-by: Leonardo Bonacci <aabcehmu@mailfence.com> remove usage of var
purbon
added a commit
that referenced
this pull request
Aug 18, 2021
…feature branches and add ConfigurationKeyValidation and TopicNameRegexValidation validations (#274) * add a validate option for the CLI, this would allow only to run validations in the topology. This would be without access to the cluster, if validations are required with the connectivity they would need to use the dry run parameter * add validation for config keys in topics * Add a TopicNameRegexValidation to validate topic names * simplify the code by making the validation a topic one and add test for this module * make the config value a constant for the topic name regexp * docs update Co-authored-by: Leonardo Bonacci <aabcehmu@mailfence.com> remove usage of var
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add a validate only flag to allow easier validation of topologies within the context of feature branches and configured validations.
As well this PR adds two new validations:
closes #165