Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing Schema Registry ACLs #297

Merged
merged 4 commits into from
Sep 17, 2021
Merged

Conversation

solita-juusoma
Copy link
Contributor

@solita-juusoma solita-juusoma commented Jun 22, 2021

  • Please check if the PR fulfills these requirements
  • The commit messages are descriptive
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • An issue has been created for the pull requests. Some issues might require previous discussion.

Adds field consumer_offsets_topic under platform schema_registry instances.

platform:
  schema_registry:
    instances:
      - principal: "User:schema_registry"
         topic: "foo"
         consumer_offsets_topic: "foo_offsets"  # new field
         group: "bar"
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Change is now done so that it won't break anything but introduces new fields and additional ACLs that are required for schema-registry principal.

  • Other information:

topic field is not that descriptive. Should be something like schemas_topic but changing it would make it breaking change. I am not sure is somebody using the functionality currently because I don't see how it would work (without GROUP and required ACLs) ? Therefore could be possible to change the name

@github-actions github-actions bot closed this Aug 9, 2021
@purbon purbon reopened this Aug 11, 2021
@kafka-ops kafka-ops deleted a comment from github-actions bot Sep 10, 2021
@purbon purbon marked this pull request as ready for review September 17, 2021 14:36
@purbon purbon self-requested a review September 17, 2021 14:41
Copy link
Collaborator

@purbon purbon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contributions @solita-juusoma

@purbon purbon merged commit 1ee68c5 into kafka-ops:master Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple subject-level RBAC bindings per principal are ignored Schema Registry ACLs missing
2 participants