Sign rpm and deb packages after building #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@purbon we could also consider adding the public key in the relases as an artifact 🤔 |
Fobhep
changed the title
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
@purbon repinging to prevent automatic closing :) |
|
Nice, I really like it! and I appreciate a ton! would this be ok to merge for your opinion? Looking forward to get this in ;-) |
|
do you mind revert the delete of all files under release/* ? they are very useful for me locally to play with ;-) |
Fobhep
force-pushed
the
signed_builds
branch
2 times, most recently
from
a91b010 to
103aee1
Compare
|
Awesome @Fobhep , looking really good! I appreciate a ton. As soon as I get time I will make sure to make a signed release using your contribution. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #303
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature
What is the current behavior? (You can also link to an open issue here)
Deb and Rpms are not signed
What is the new behavior (if this is a feature change)?
Deb and Rpms are signed
Other information:
In order to get it running we need the following repo secrets:
GPG_PRIVATE_KEY-> the armored export of the private gpg keyas described here: https://github.com/marketplace/actions/import-gpg
GPG_PASSPHRASE-> the pass phrase for the private pgp keyFurthermore we need in
release/keys/public.keythe matching public part - also armored exported