Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Unrecognized field "resource_id" (#307) #309

Merged
merged 2 commits into from
Aug 18, 2021

Conversation

mvanbrummen
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • [ x] The commit messages are descriptive
  • [ x] Tests for the changes have been added (for bug fixes / features)
  • [ x] Docs have been added / updated (for bug fixes / features)
  • [x ] An issue has been created for the pull requests. Some issues might require previous discussion.
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Bug fix:

Added resource_id property to ServiceAccount to remove JSON error.

When attempting to manage Confluent Cloud service accounts with the JulieOps CLI tool while using any version of ccloud above v1.27.0, the error message:

com.fasterxml.jackson.databind.exc.UnrecognizedPropertyException: Unrecognized field "resource_id" (class com.purbon.kafka.topology.model.cluster.ServiceAccount), not marked as ignorable (3 known properties: "id", "description", "name"])

appears in the output.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

No

@purbon purbon self-requested a review August 18, 2021 14:11
@purbon purbon added the test-required PR with missing test coverage label Aug 18, 2021
@purbon
Copy link
Collaborator

purbon commented Aug 18, 2021

Hi @mvanbrummen thanks a lot for your contribution, I much appreciate it. I know is not well covered for all things, but I would appreciate adding tests ;-) I will try to ask all the time this in the future jejejejje

@purbon purbon merged commit b5307e2 into kafka-ops:master Aug 18, 2021
sverrehu pushed a commit to sverrehu/julie that referenced this pull request Aug 19, 2021
* Added resourceId to ServiceAccount.java to support ccloud v1.28.0+

* Added @JsonProperty to match resource_id in service account json
@purbon purbon linked an issue Sep 11, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test-required PR with missing test coverage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unrecognized field "resource_id"
2 participants