Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the capability to generate DLQ auto generated topic for a given topology #357

Merged
merged 1 commit into from
Oct 19, 2021

Conversation

purbon
Copy link
Collaborator

@purbon purbon commented Oct 14, 2021

  • Please check if the PR fulfills these requirements
  • The commit messages are descriptive
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • An issue has been created for the pull requests. Some issues might require previous discussion.
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Other information:

close #356

@purbon purbon changed the title First try adding and glagging extra DLQ topics for generated topics Add capacity to generate DLQ auto generated topic for a given topology. Oct 14, 2021
@purbon purbon changed the title Add capacity to generate DLQ auto generated topic for a given topology. Add capacity to generate DLQ auto generated topic for a given topology Oct 14, 2021
add initial test for dlq topic generation

add extra test for dlq topic generation

more tests for dlq criteria

make sure config is the same for dlq topics

introduce a dlq topic prefix format and label, so users can decide how they dlq topic naming would be

add couple of bits of info about how to deal with DLQ topics in the docs section

add dlq feature section in the docs
@purbon purbon force-pushed the feature/add-dlq-topic-support branch from 63327be to 911d1d4 Compare October 19, 2021 16:35
@purbon purbon changed the title Add capacity to generate DLQ auto generated topic for a given topology Add the option to generate DLQ auto generated topic for a given topology Oct 19, 2021
@purbon purbon changed the title Add the option to generate DLQ auto generated topic for a given topology Add the capability to generate DLQ auto generated topic for a given topology Oct 19, 2021
@purbon purbon merged commit 278de7d into master Oct 19, 2021
@purbon purbon deleted the feature/add-dlq-topic-support branch December 9, 2021 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JulieOps should support out of the box the creation of DLQ topics
1 participant