Introduce Kafka as backend store implementation #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
purbon
commented
Oct 16, 2021
•
purbon
commented
- Please check if the PR fulfills these requirements
- The commit messages are descriptive
- Tests for the changes have been added (for bug fixes / features)
- Docs have been added / updated (for bug fixes / features)
- An issue has been created for the pull requests. Some issues might require previous discussion.
purbon
force-pushed
the
feature/state-store-kafka
branch
2 times, most recently
from
88740db to
0f304c9
Compare
…sm for julieops wire up use lombook to simplify getters and setters for topics clean up users class with annotations ammend user pojo lombokeed the config file Revert "lombokeed the config file" This reverts commit d8fc6e4. crappy solution for passing the test, needs lots of improved and backend could not start until consumer is up and running wait until there is a record received before finishing the configuration some more test close proper backend add extra sleep cleanup debugging logs add code and test to ensure always an instance ID fix test
purbon
force-pushed
the
feature/state-store-kafka
branch
from
641f3b8 to
939b0da
Compare
purbon
commented
Oct 26, 2021
| @@ -131,4 +134,7 @@ | |||
| public static final String SSL_KEY_PASSWORD = "ssl.key.password"; | |||
|
|
|||
| public static final String JULIE_ROLES = "julie.roles"; | |||
|
|
|||
| public static final String JULIE_KAFKA_CONFIG_TOPIC = "julie.kafka.config.topic"; | |||
| public static final String JULIE_INSTANCE_ID = "julie.instance.id"; | |||
There was a problem hiding this comment.
This could be improved by allowing ENV overwrite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.