Throw exception for invalid plan name #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akselh
reviewed
Dec 17, 2021
src/main/java/com/purbon/kafka/topology/serdes/TopicCustomDeserializer.java
Outdated
Show resolved
Hide resolved
…rializer.java Co-authored-by: Aksel Hilde <42339256+akselh@users.noreply.github.com>
|
Definitively agree! Reference to non-existing plan should fail the pipeline, not just give a warning that will be missed (in reality). |
akselh
reviewed
Dec 17, 2021
src/main/java/com/purbon/kafka/topology/serdes/TopicCustomDeserializer.java
Outdated
Show resolved
Hide resolved
|
LGTM |
purbon
approved these changes
Dec 18, 2021
|
Thanks, Pere! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have had a couple of incidents where people have misspelled the plan name. JulieOps logs a warning about this and falls back to default configuration. Nobody sees the warning, so the result is incorrectly configured topics that nobody notices before it is too late.
I think it makes no sense to let people specify a plan that does not exist, so this PR will change the warning to an exception.