Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ksqlDB] when using ACLs configure all internal topics with ALL permissions for the ksql server user #433

Merged
merged 7 commits into from
Dec 30, 2021
Merged

[ksqlDB] when using ACLs configure all internal topics with ALL permissions for the ksql server user #433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a253cc8
Update testcontainers.version to 1.15.3 that includes JNA dependency …
solita-juusoma Jun 21, 2021
cff6b47
Add required ACLs for schema-registry instances
solita-juusoma Jun 21, 2021
7e444b6
Fix typo in schemaregistryinstance class and add CREATE acl for schem…
solita-juusoma Jun 22, 2021
684e529
Change offset topic ACL DescribeConfigs to Describe
solita-juusoma Jun 23, 2021
c38f694
Merge branch 'master' of https://github.com/kafka-ops/julie
solita-juusoma Dec 28, 2021
09bfcb0
Fix ksql server instance ACLs
solita-juusoma Dec 29, 2021
359060f
Revert command topic method and RBAC ACLs
solita-juusoma Dec 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/main/java/com/purbon/kafka/topology/model/users/platform/KsqlServerInstance.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,10 @@ public String getOwner() {
return owner;
}

public String commandTopic() {
return String.format("_confluent-ksql-%s_command_topic", ksqlDbId);
public String commandTopic() { return String.format("_confluent-ksql-%s_command_topic", ksqlDbId); }

public String internalTopics() {
solita-juusoma marked this conversation as resolved.
Show resolved Hide resolved
return String.format("_confluent-ksql-%s", ksqlDbId);
}

public String processingLogTopic() {
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/purbon/kafka/topology/roles/acls/AclsBindingsBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,7 @@ private Stream<AclBinding> ksqlServerStream(KsqlServerInstance ksqlServer) {

bindings.add(
buildTopicLevelAcl(
principal, ksqlServer.commandTopic(), PatternType.LITERAL, AclOperation.ALL));
principal, ksqlServer.internalTopics(), PatternType.PREFIXED, AclOperation.ALL));
bindings.add(
buildTopicLevelAcl(
principal, ksqlServer.processingLogTopic(), PatternType.LITERAL, AclOperation.ALL));
Expand Down