Fix Confluent Cloud ACL(s) API usage, so ACL(s) are finally created properly #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…countIDs as expected by the internal system
… future for service account id(s)
|
@purbon will a new release and Docker image be cut containing this fix? Thanks |
|
for sure, i do as soon as possible
…On Fri, 4 Feb 2022, 20:11 Michael Beausoleil ***@***.***> wrote:
@purbon <https://github.com/purbon> will a new release and Docker image
be cut containing this fix? Thanks
—
Reply to this email directly, view it on GitHub
<#444 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAQXPAQCWPHA7PVXXQKJA3UZQQEXANCNFSM5NSBLB3A>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
purbon
added a commit
that referenced
this pull request
Feb 5, 2022
…roperly (#444) * add few calls to translate String ServiceAccountLabels into proper AccountIDs as expected by the internal system * add configuration variable to control the confluent cloud translation future for service account id(s) * simplify topic only descriptor * add log information for when the translation process happends * update the julieops example for confluent cloud with more interesting configs * code simplification * more simplification * ammend typo * ammend formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #438