Add feature flag to make the remote state verification backwards compatible again

[purbon]

to be removed in future versions and make true by default.

[purbon]

@akselh @sverrehu This should bring this feature backwards compatible again, as it should have always been ;-) sorry for the hassle. I will make a new version rather soon, sorry been lately slammed by work.

[sverrehu]

Would it be better to print the warning in one, central place? Then you would avoid both duplicated code and "spammed" logs.

[purbon]

@sverrehu probably true, but I kinda need this change soon for a project ;-) ... I will improve the code in next iterations as this central place would require some reworking of the class structure (totally need anyway).

[akselh]

Thanks for fixing this issue @purbon!

When this is later removed it is important to handle the existing features of config ALLOW_XXX being false. For example in the case ALLOW_DELETE_TOPICS=false the normal flow of work will be to remove the topic from the topology first and then remove it from the cluster.

[purbon]

That makes sense Aksel

…

-- Pere

On Wed, Apr 27, 2022 at 11:30 AM Aksel Hilde ***@***.***> wrote: Thanks for fixing this issue @purbon <https://github.com/purbon>! When this is later removed it is important to handle the existing features of config ALLOW_XXX being false. For example in the case ALLOW_DELETE_TOPICS=false the normal flow of work will be to remove the topic from the topology first and then remove it from the cluster. — Reply to this email directly, view it on GitHub <#491 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAQXPFYSCRW4AGPO5SHJ5TVHECNBANCNFSM5UMQ7FTA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- Pere Urbon-Bayes Software Architect https://twitter.com/purbon https://www.linkedin.com/in/purbon/