Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't print empty operations #517

Merged
merged 1 commit into from
Aug 3, 2022

Conversation

sverrehu
Copy link
Contributor

@sverrehu sverrehu commented Aug 1, 2022

  • Please check if the PR fulfills these requirements
  • [* ] The commit messages are descriptive
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • An issue has been created for the pull requests. Some issues might require previous discussion.
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Fix for #510

I only changed ExecutionPlan.java and TopicManagerTest.java. The other two files were changed due to the embedded formatter.

@purbon
Copy link
Collaborator

purbon commented Aug 2, 2022

❤️ thanks a lot for your contributions @sverrehu! you guys really rock and are super helpful!

@purbon
Copy link
Collaborator

purbon commented Aug 2, 2022

re: due to the embedded formatter.
I do really have to find a better way, it piss me off often this formatter :-(

@sverrehu
Copy link
Contributor Author

sverrehu commented Aug 2, 2022

❤️ thanks a lot for your contributions @sverrehu! you guys really rock and are super helpful!

I think I was the one who introduced those blank lines in the first place. ;-) But thanks!

@purbon purbon requested review from purbon and removed request for purbon August 3, 2022 06:56
@purbon purbon changed the title Don't print empty operations Don't print empty operations during dryRun Aug 3, 2022
@purbon purbon changed the title Don't print empty operations during dryRun Don't print empty operations Aug 3, 2022
@purbon purbon merged commit 3765517 into kafka-ops:master Aug 3, 2022
purbon pushed a commit that referenced this pull request Aug 22, 2022
@sverrehu sverrehu deleted the dont-print-empty-operations branch March 22, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants