Fix loads of things #185
Merged
Fix loads of things #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing into an error...
Should we pull those into KaHyPar as well? |
There is no immediate need. The changes affect bulk piercing and push-relabel, both of which are not used in KaHyPar at the moment. |
N-Maas
reviewed
Sep 23, 2024
| @@ -763,7 +763,7 @@ namespace mt_kahypar::io { | |||
| std::sort(internal_pins.begin(), internal_pins.end()); | |||
| std::sort(internal_degree.begin(), internal_degree.end()); | |||
|
|
|||
| auto square = [&](size_t x) { return x * x; }; | |||
| auto square = [&](double x) { return x * x; }; | |||
There was a problem hiding this comment.
This is actually no UB since unsigned overflow is well defined, but of course produces wrong results^^
|
|
||
| #include "mt-kahypar/partition/refinement/gains/gain_definitions.h" | ||
| #include "mt-kahypar/utils/cast.h" | ||
| #include "mt-kahypar/partition/context.h" | ||
|
|
||
| #include "pcg_random.hpp" | ||
|
|
There was a problem hiding this comment.
This means we can also remove pcg from external_tools, right? It would be good to also include this in the PR
kittobi1992
reviewed
Sep 23, 2024
| @@ -87,7 +87,9 @@ class ConnectivitySets { | |||
| _shallow_copy_bitset() { | |||
| if ( num_hyperedges > 0 ) { | |||
| _bits.resize("Refinement", "connectivity_set", | |||
| static_cast<size_t>(num_hyperedges) * _num_blocks_per_hyperedge, true, assign_parallel); | |||
| static_cast<size_t>(num_hyperedges) * _num_blocks_per_hyperedge | |||
| + 1 // The nextBlockID() implementation performs a (masked out) load past the end | |||
There was a problem hiding this comment.
Or this way or remove the comment:
Suggested change
| + 1 // The nextBlockID() implementation performs a (masked out) load past the end | |
| + 1 /* The nextBlockID() implementation performs a (masked out) load past the end */ |
| @@ -195,7 +194,10 @@ namespace mt_kahypar { | |||
| template<typename TypeTraits> | |||
| void MultilevelUncoarsener<TypeTraits>::refineImpl() { | |||
| PartitionedHypergraph& partitioned_hypergraph = *_uncoarseningData.partitioned_hg; | |||
| const double time_limit = Base::refinementTimeLimit(_context, (_uncoarseningData.hierarchy)[_current_level].coarseningTime()); | |||
| double time_limit = std::numeric_limits<double>::max(); | |||
| if (_current_level >= 0 && _current_level != _num_levels) { // there is a refinement run on the coarsest graph before projection, there is no value stored for this run. | |||
| return 0; | ||
| } | ||
|
|
||
| HyperedgeWeight distance(const PartitionID , const PartitionID ) const { |
There was a problem hiding this comment.
Formatting (also apply to other functions)
Suggested change
| HyperedgeWeight distance(const PartitionID , const PartitionID ) const { | |
| HyperedgeWeight distance(const PartitionID, const PartitionID) const { |
N-Maas
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make includes compatible with some non-standard build systems 😔
Some UB and ASAN fixes in uncoarsening and priority queue
Some WHFC assertion fixes + underflow