Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings #193

Merged
merged 20 commits into from
Oct 16, 2024
Merged

Fix warnings #193

merged 20 commits into from
Oct 16, 2024

Commits on Sep 30, 2024

  1. update pybind submodule

    @N-Maas
    N-Maas committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    d49337c View commit details
    Browse the repository at this point in the history

  2. fix null pointer warning

    @N-Maas
    N-Maas committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    42b6d9b View commit details
    Browse the repository at this point in the history

  3. update googletest submodule

    @N-Maas
    N-Maas committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    88bd0d9 View commit details
    Browse the repository at this point in the history

  4. fix for coarsener 

    These write were redundant. Also, the state of u would be updated to
MATCHED before v. However, the code expects that v is updated before u
(see assertion in line 388).
    @N-Maas
    N-Maas committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    e146a01 View commit details
    Browse the repository at this point in the history

  5. make coarsener code slightly easier to follow

    @N-Maas
    N-Maas committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    a971d48 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. fix some clang warnings in tests

    @N-Maas
    N-Maas committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    42de03e View commit details
    Browse the repository at this point in the history

  2. replace deprecated TYPED_TEST_CASE with TYPED_TEST_SUITE

    @N-Maas
    N-Maas committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    41f6899 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. suppress clang warnings for growt

    @N-Maas
    N-Maas committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    ffa0215 View commit details
    Browse the repository at this point in the history

  2. remove unused variable

    @N-Maas
    N-Maas committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    c599dd0 View commit details
    Browse the repository at this point in the history

  3. suppress some clang warnings related to gtest

    @N-Maas
    N-Maas committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    5a0ae5a View commit details
    Browse the repository at this point in the history

  4. remove warning suppression by fixing the warning

    @N-Maas
    N-Maas committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    a7fb47b View commit details
    Browse the repository at this point in the history

  5. more unused variables

    @N-Maas
    N-Maas committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    6bf2bd5 View commit details
    Browse the repository at this point in the history

  6. fix for mtx converter

    @N-Maas
    N-Maas committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    97632af View commit details
    Browse the repository at this point in the history

  7. one more unused variable

    @N-Maas
    N-Maas committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    340babd View commit details
    Browse the repository at this point in the history

  8. fix some more warnings 

    Note: removing explicit constructor since it interferes with implicit
constructor/implicit assignment operator
    @N-Maas
    N-Maas committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    6adab00 View commit details
    Browse the repository at this point in the history

  9. ouch

    @N-Maas
    N-Maas committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    eb34ab1 View commit details
    Browse the repository at this point in the history

  10. remove members only used by assertions if assertions are off 

    triggers unused warnings by clang otherwise
    @N-Maas
    N-Maas committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    45a7015 View commit details
    Browse the repository at this point in the history

  11. unused variable

    @N-Maas
    N-Maas committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    2702283 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. specify memory orderings for coarsening code

    @N-Maas
    N-Maas committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    cc088ca View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. update comment on memory ordering

    @N-Maas
    N-Maas committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    76bbeaa View commit details
    Browse the repository at this point in the history