tracers: debug APIs and chaindatafetcher use new vm.CallTracer #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
blukat29
force-pushed
the
api-new-calltracer
branch
from
7f8692e to
6dadef3
Compare
9 tasks
blukat29
force-pushed
the
api-new-calltracer
branch
from
6dadef3 to
db6615e
Compare
blukat29
changed the title
blukat29
force-pushed
the
api-new-calltracer
branch
from
db6615e to
ff0eed4
Compare
blukat29
requested review from
hyunsooda,
2dvorak,
kjeom,
JayChoi1736,
aidan-kwon,
jeongkyun-oh,
yoomee1313,
sjnam,
ian0371 and
hyeonLewis
as code owners
ian0371
reviewed
Jul 3, 2024
Fix this error
```
panic: interface conversion: interface {} is json.RawMessage, not *vm.InternalTxTrace
goroutine 936 [running]:
github.com/klaytn/klaytn/datasync/chaindatafetcher.(*ChainDataFetcher).makeChainEvent(0xc08a357900, 0x4c4b401)
/home/ec2-user/kaia/datasync/chaindatafetcher/chaindata_fetcher.go:323 +0xb30
github.com/klaytn/klaytn/datasync/chaindatafetcher.(*ChainDataFetcher).handleRequest(0xc08a357900)
/home/ec2-user/kaia/datasync/chaindatafetcher/chaindata_fetcher.go:476 +0x1f4
created by github.com/klaytn/klaytn/datasync/chaindatafetcher.(*ChainDataFetcher).Start in goroutine 1
/home/ec2-user/kaia/datasync/chaindatafetcher/chaindata_fetcher.go:174 +0x25
```
blukat29
force-pushed
the
api-new-calltracer
branch
from
54577cc to
23707d7
Compare
jeongkyun-oh
reviewed
Jul 3, 2024
jeongkyun-oh
reviewed
Jul 3, 2024
jeongkyun-oh
reviewed
Jul 3, 2024
jeongkyun-oh
approved these changes
Jul 3, 2024
ian0371
approved these changes
Jul 3, 2024
hyeonLewis
approved these changes
Jul 3, 2024
2dvorak
approved these changes
Jul 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
callTracerwas previouslycall_tracer.jsand is nowvm.CallTracerfastCallTracerwas previouslyvm.InternalTxTracerand is nowvm.CallTracerChainEvent.InternalTxTraces(enabled when--vm.internaltx) was previously produced byvm.InternalTxTracerand is nowvm.CallTracer, but preserves the originalInternalTxTraceoutput format.Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
I have read the CLA Document and I hereby sign the CLAin first time contribute$ make test)Related issues
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...