kaiax/gov: Replace remaining with gov #177
Open
+234
−76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
headergov.Init initializes govData with zero
blukat29
reviewed
Dec 12, 2024
blukat29
reviewed
Dec 12, 2024
blukat29
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR is a sequel of #162.
Types of changes
Checklist
I have read the CLA Document and I hereby sign the CLAin first time contribute$ make test)Further comments
MixedEngine method replaced by GovModule
It excludes
governancedirectory, as they will be removed.MixedEngine methods that will be completely removed by ValSet module
These will be removed after introducing ValSet module.
ChainConfig replaced by GovModule
node/cn/backend.go:New: UnitPrice. Removed because it's unused.blockchain/types/derivesha/mux.go:getType: DeriveShaImpl.ChainConfig left as-is
There are cases when the genesis chain config can be used. Either it's immutable, or not essential to use the latest value.
blockchain/genesis.go:SetGenesisGovernance: initial 13 parameters. Not called byken init.accounts/abi/bind/backends.go:SuggestGasPrice: UnitPrice. The value does not matter. Also, importing GovModule results in import cycle.datasync/dbsyncer/dbsync.go:syncBlockHeader: UnitPrice. The value does not matter.datasync/dbsyncer/dbsync_context.go:syncBlockHeaderContext: UnitPrice. The value does not matter.datasync/dbsyncer/dbsync_multi.go:parallelSyncBlockHeader: UnitPrice. The value does not matter.blockchain/genesis.go:SetupGenesisBlock: StakingUpdateInterval, ProposerUpdateInterval. The value is immutable.cmd/utils/nodecmd/chaincmd.go:initGenesis: StakingUpdateInterval, ProposerUpdateInterval. The value is immutable.blockchain/genesis.go:ToBlock: LowerBoundBaseFee. Genesis config must be used.kaiax/staking/impl/init.go:Init: StakingUpdateInterval, UseGiniCoeff, MinimumStake. The value is immutable.node/cn/handler.go:{handleStakingInfoRequestMsg,handleStakingInfoMsg}: UseGiniCoeff, MinimumStake. The value is immutable.blockchain/state_transition.go:TransitionDb: DeferredTxFee. The value is immutable. Also, adding GovModule to the object is difficult.cmd/utils/nodecmd/chaincmd.go:ValidateGenesisConfig: ProposerUpdateInterval, StakingUpdateInterval, GovernanceMode, GoverningNode. Genesis config must be used.blockchain/blockchain.go:isCommitTrieRequired: ProposerPolicy. The value is immutable.blockchain/blockchain.go:setHeadBeyondRoot: Epoch. The value is immutable.consensus/istanbul/backend/engine.go:Finalize: ProposerPolicy. The value is immutable.node/cn/handler.go:{handleStakingInfoRequestMsg,handleStakingInfoMsg}: ProposerPolicy. The value is immutable.ChainConfig replaced by GovModule
node/cn/backend.go:New: UnitPrice. Removed because it's unused.blockchain/types/derivesha/mux.go:getType: DeriveShaImpl.ChainConfig that will be completely removed by ValSet module
These will be removed after introducing ValSet module.consensus/istanbul/backend/backend.go:{ParentValidators,getValidators}: ProposerPolicy, SubGroupSize.consensus/istanbul/validator/weighted.go:RefreshValSet: UseGiniCoeff.