reward: SupplyManager reaccumulates from nearest persisted AccReward #62
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
kaia_getTotalSupply
for non-128-multiple blocks.AccReward
every BlockInterval. The intention was to make full nodes write everyBlockInterval
whereas archive nodes write every1
block.BlockInterval == 128 (default)
because it didn't matter so far. The writeStateTrie loop ignores BlockInterval when gcmode is archive.AccReward
every1
block. Rather it stored every 128 blocks in archive nodes with default settings.AccReward
for any given block, by re-accumulating from the nearest persistedAccReward
.Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
I have read the CLA Document and I hereby sign the CLA
in first time contribute$ make test
)Related issues
Further comments