This repository has been archived by the owner on Dec 30, 2021. It is now read-only.
Modernization #105
Merged
Modernization #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- replace Q.defer with native Promises - use arrow functions
kaimallea
commented
Mar 4, 2021
| mockfs({ | ||
| '/home/user/meme.jpg': Buffer.from([8, 6, 7, 5, 3, 0, 9]), | ||
| '/home/user/lol.jpg': Buffer.from([9, 0, 3, 5, 7, 6, 8]), | ||
| }); |
There was a problem hiding this comment.
mock file system available in all tests. any fs.* method will think these are real. key == file, value == file contents
kaimallea
commented
Mar 4, 2021
| }; | ||
| return res(ctx.json(response)); | ||
| }), | ||
| ]; |
There was a problem hiding this comment.
mock response handler used for uploadFile test. As easy as adding more handlers to mock responses for other methods.
BREAKING CHANGE: uploadFile no longer accepts a glob pattern. It now accepts either a single image path or an array of image paths. If you must glob, do it yourself and then pass in the array. This removes an unnecessary complexity from the most important method.
KenEucker
approved these changes
Mar 4, 2021
There was a problem hiding this comment.
@kaimallea looks good to me!
I was able to successfully run all of the tests on my machine.
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor modernization tweaks. Most important change here is the mocking that makes uploadFile testable
cc @KenEucker if you still have an interest (no pressure)