-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull up "times" operation #10
Commits on Sep 29, 2022
-
inline factory methods in Dollar.times and Franc.times
Tasklist: - $5 + 10CHF = $10 if rate is 2:1 🎯 - $5 * 2 = $10 ✅ - Make "amount" private ✅ - Dollar side-effects? ✅ - Money rounding? - equals() ✅ - Equal null - Equal object - 5 CHF * 2 = 10 CHF ✅ - Dollar/Franc duplication - Common `.equals` ✅ - Common `.times` 👈🏼 - Compare Francs with Dollars ✅ - Currency? ✅ - Merge multiplication tests?
Configuration menu - View commit details
-
Copy full SHA for 99e36ad - Browse repository at this point
Copy the full SHA 99e36adView commit details -
Tasklist: - $5 + 10CHF = $10 if rate is 2:1 🎯 - $5 * 2 = $10 ✅ - Make "amount" private ✅ - Dollar side-effects? ✅ - Money rounding? - equals() ✅ - Equal null - Equal object - 5 CHF * 2 = 10 CHF ✅ - Dollar/Franc duplication - Common `.equals` ✅ - Common `.times` 👈🏼 - Compare Francs with Dollars ✅ - Currency? ✅ - Merge multiplication tests?
Configuration menu - View commit details
-
Copy full SHA for 3401350 - Browse repository at this point
Copy the full SHA 3401350View commit details -
add test to verify different class equality when currency and amount …
…are the same Tasklist: - $5 + 10CHF = $10 if rate is 2:1 🎯 - $5 * 2 = $10 ✅ - Make "amount" private ✅ - Dollar side-effects? ✅ - Money rounding? - equals() ✅ - Equal null - Equal object - 5 CHF * 2 = 10 CHF ✅ - Dollar/Franc duplication - Common `.equals` ✅ - Common `.times` 👈🏼 - Compare Francs with Dollars ✅ - Currency? ✅ - Merge multiplication tests?
Configuration menu - View commit details
-
Copy full SHA for 79ca053 - Browse repository at this point
Copy the full SHA 79ca053View commit details -
change equality logic to use current field instead of checking the co…
…nstructor type Tasklist: - $5 + 10CHF = $10 if rate is 2:1 🎯 - $5 * 2 = $10 ✅ - Make "amount" private ✅ - Dollar side-effects? ✅ - Money rounding? - equals() ✅ - Equal null - Equal object - 5 CHF * 2 = 10 CHF ✅ - Dollar/Franc duplication - Common `.equals` ✅ - Common `.times` 👈🏼 - Compare Francs with Dollars ✅ - Currency? ✅ - Merge multiplication tests?
Configuration menu - View commit details
-
Copy full SHA for ae56fe6 - Browse repository at this point
Copy the full SHA ae56fe6View commit details -
make Dollar return an instance of Money in Dollar.times
Tasklist: - $5 + 10CHF = $10 if rate is 2:1 🎯 - $5 * 2 = $10 ✅ - Make "amount" private ✅ - Dollar side-effects? ✅ - Money rounding? - equals() ✅ - Equal null - Equal object - 5 CHF * 2 = 10 CHF ✅ - Dollar/Franc duplication - Common `.equals` ✅ - Common `.times` 👈🏼 - Compare Francs with Dollars ✅ - Currency? ✅ - Merge multiplication tests?
Configuration menu - View commit details
-
Copy full SHA for d2c5996 - Browse repository at this point
Copy the full SHA d2c5996View commit details -
make Franc return an instance of Money in Franc.times
Tasklist: - $5 + 10CHF = $10 if rate is 2:1 🎯 - $5 * 2 = $10 ✅ - Make "amount" private ✅ - Dollar side-effects? ✅ - Money rounding? - equals() ✅ - Equal null - Equal object - 5 CHF * 2 = 10 CHF ✅ - Dollar/Franc duplication - Common `.equals` ✅ - Common `.times` 👈🏼 - Compare Francs with Dollars ✅ - Currency? ✅ - Merge multiplication tests?
Configuration menu - View commit details
-
Copy full SHA for a8c9823 - Browse repository at this point
Copy the full SHA a8c9823View commit details -
return current currency when performing Dollar.times instead of hardc…
…oded USD Tasklist: - $5 + 10CHF = $10 if rate is 2:1 🎯 - $5 * 2 = $10 ✅ - Make "amount" private ✅ - Dollar side-effects? ✅ - Money rounding? - equals() ✅ - Equal null - Equal object - 5 CHF * 2 = 10 CHF ✅ - Dollar/Franc duplication - Common `.equals` ✅ - Common `.times` 👈🏼 - Compare Francs with Dollars ✅ - Currency? ✅ - Merge multiplication tests?
Configuration menu - View commit details
-
Copy full SHA for 924d12e - Browse repository at this point
Copy the full SHA 924d12eView commit details -
return current currency instead of hardcoded CHF when executing Franc…
….times Tasklist: - $5 + 10CHF = $10 if rate is 2:1 🎯 - $5 * 2 = $10 ✅ - Make "amount" private ✅ - Dollar side-effects? ✅ - Money rounding? - equals() ✅ - Equal null - Equal object - 5 CHF * 2 = 10 CHF ✅ - Dollar/Franc duplication - Common `.equals` ✅ - Common `.times` 👈🏼 - Compare Francs with Dollars ✅ - Currency? ✅ - Merge multiplication tests?
Configuration menu - View commit details
-
Copy full SHA for 0d89759 - Browse repository at this point
Copy the full SHA 0d89759View commit details -
pull up .times operation to Money class
Tasklist: - $5 + 10CHF = $10 if rate is 2:1 🎯 - $5 * 2 = $10 ✅ - Make "amount" private ✅ - Dollar side-effects? ✅ - Money rounding? - equals() ✅ - Equal null - Equal object - 5 CHF * 2 = 10 CHF ✅ - Dollar/Franc duplication - Common `.equals` ✅ - Common `.times` ✅ - Compare Francs with Dollars ✅ - Currency? ✅ - Merge multiplication tests?
Configuration menu - View commit details
-
Copy full SHA for 8dd269f - Browse repository at this point
Copy the full SHA 8dd269fView commit details