Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete franc and dollar classes #11

Merged
merged 7 commits into from
Sep 29, 2022
Merged

Delete franc and dollar classes #11

merged 7 commits into from
Sep 29, 2022

Commits on Sep 29, 2022

  1. return Money instance when calling Money.franc 

    Tasklist:
- $5 + 10CHF = $10 if rate is 2:1 🎯
- $5 * 2 = $10 ✅
- Make "amount" private ✅
- Dollar side-effects? ✅
- Money rounding?
- equals() ✅
- Equal null
- Equal object
- 5 CHF * 2 = 10 CHF ✅
- Dollar/Franc duplication 👈🏼
- Common `.equals` ✅
- Common `.times` ✅
- Compare Francs with Dollars ✅
- Currency? ✅
- Merge multiplication tests?
    @kaiosilveira
    kaiosilveira committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    83efdab View commit details
    Browse the repository at this point in the history

  2. return Money instance when calling Moeny.dollar 

    Tasklist:
- $5 + 10CHF = $10 if rate is 2:1 🎯
- $5 * 2 = $10 ✅
- Make "amount" private ✅
- Dollar side-effects? ✅
- Money rounding?
- equals() ✅
- Equal null
- Equal object
- 5 CHF * 2 = 10 CHF ✅
- Dollar/Franc duplication 👈🏼
- Common `.equals` ✅
- Common `.times` ✅
- Compare Francs with Dollars ✅
- Currency? ✅
- Merge multiplication tests?
    @kaiosilveira
    kaiosilveira committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    533e745 View commit details
    Browse the repository at this point in the history

  3. delete redundant test covering different class equality 

    Tasklist:
- $5 + 10CHF = $10 if rate is 2:1 🎯
- $5 * 2 = $10 ✅
- Make "amount" private ✅
- Dollar side-effects? ✅
- Money rounding?
- equals() ✅
- Equal null
- Equal object
- 5 CHF * 2 = 10 CHF ✅
- Dollar/Franc duplication 👈🏼
- Common `.equals` ✅
- Common `.times` ✅
- Compare Francs with Dollars ✅
- Currency? ✅
- Merge multiplication tests?
    @kaiosilveira
    kaiosilveira committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    b1ce340 View commit details
    Browse the repository at this point in the history

  4. remove redundant assertions in equality test 

    Tasklist:
- $5 + 10CHF = $10 if rate is 2:1 🎯
- $5 * 2 = $10 ✅
- Make "amount" private ✅
- Dollar side-effects? ✅
- Money rounding?
- equals() ✅
- Equal null
- Equal object
- 5 CHF * 2 = 10 CHF ✅
- Dollar/Franc duplication 👈🏼
- Common `.equals` ✅
- Common `.times` ✅
- Compare Francs with Dollars ✅
- Currency? ✅
- Merge multiplication tests?
    @kaiosilveira
    kaiosilveira committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    1678aaa View commit details
    Browse the repository at this point in the history

  5. remove unused Franc import in Money test 

    Tasklist:
- $5 + 10CHF = $10 if rate is 2:1 🎯
- $5 * 2 = $10 ✅
- Make "amount" private ✅
- Dollar side-effects? ✅
- Money rounding?
- equals() ✅
- Equal null
- Equal object
- 5 CHF * 2 = 10 CHF ✅
- Dollar/Franc duplication 👈🏼
- Common `.equals` ✅
- Common `.times` ✅
- Compare Francs with Dollars ✅
- Currency? ✅
- Merge multiplication tests?
    @kaiosilveira
    kaiosilveira committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    f9d36b7 View commit details
    Browse the repository at this point in the history

  6. remove Dollar and Franc subclasses 

    Tasklist:
- $5 + 10CHF = $10 if rate is 2:1 🎯
- $5 * 2 = $10 ✅
- Make "amount" private ✅
- Dollar side-effects? ✅
- Money rounding?
- equals() ✅
- Equal null
- Equal object
- 5 CHF * 2 = 10 CHF ✅
- Dollar/Franc duplication ✅
- Common `.equals` ✅
- Common `.times` ✅
- Compare Francs with Dollars ✅
- Currency? ✅
- Merge multiplication tests?
    @kaiosilveira
    kaiosilveira committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    f446320 View commit details
    Browse the repository at this point in the history

  7. delete Franc tests and merge Dollar tests into Money tests 

    Tasklist:
- $5 + 10CHF = $10 if rate is 2:1 🎯
- $5 * 2 = $10 ✅
- Make "amount" private ✅
- Dollar side-effects? ✅
- Money rounding?
- equals() ✅
- Equal null
- Equal object
- 5 CHF * 2 = 10 CHF ✅
- Dollar/Franc duplication ✅
- Common `.equals` ✅
- Common `.times` ✅
- Compare Francs with Dollars ✅
- Currency? ✅
- Merge multiplication tests? ✅
    @kaiosilveira
    kaiosilveira committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    8bc4230 View commit details
    Browse the repository at this point in the history