-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete franc and dollar classes #11
Commits on Sep 29, 2022
-
return Money instance when calling Money.franc
Tasklist: - $5 + 10CHF = $10 if rate is 2:1 🎯 - $5 * 2 = $10 ✅ - Make "amount" private ✅ - Dollar side-effects? ✅ - Money rounding? - equals() ✅ - Equal null - Equal object - 5 CHF * 2 = 10 CHF ✅ - Dollar/Franc duplication 👈🏼 - Common `.equals` ✅ - Common `.times` ✅ - Compare Francs with Dollars ✅ - Currency? ✅ - Merge multiplication tests?
Configuration menu - View commit details
-
Copy full SHA for 83efdab - Browse repository at this point
Copy the full SHA 83efdabView commit details -
return Money instance when calling Moeny.dollar
Tasklist: - $5 + 10CHF = $10 if rate is 2:1 🎯 - $5 * 2 = $10 ✅ - Make "amount" private ✅ - Dollar side-effects? ✅ - Money rounding? - equals() ✅ - Equal null - Equal object - 5 CHF * 2 = 10 CHF ✅ - Dollar/Franc duplication 👈🏼 - Common `.equals` ✅ - Common `.times` ✅ - Compare Francs with Dollars ✅ - Currency? ✅ - Merge multiplication tests?
Configuration menu - View commit details
-
Copy full SHA for 533e745 - Browse repository at this point
Copy the full SHA 533e745View commit details -
delete redundant test covering different class equality
Tasklist: - $5 + 10CHF = $10 if rate is 2:1 🎯 - $5 * 2 = $10 ✅ - Make "amount" private ✅ - Dollar side-effects? ✅ - Money rounding? - equals() ✅ - Equal null - Equal object - 5 CHF * 2 = 10 CHF ✅ - Dollar/Franc duplication 👈🏼 - Common `.equals` ✅ - Common `.times` ✅ - Compare Francs with Dollars ✅ - Currency? ✅ - Merge multiplication tests?
Configuration menu - View commit details
-
Copy full SHA for b1ce340 - Browse repository at this point
Copy the full SHA b1ce340View commit details -
remove redundant assertions in equality test
Tasklist: - $5 + 10CHF = $10 if rate is 2:1 🎯 - $5 * 2 = $10 ✅ - Make "amount" private ✅ - Dollar side-effects? ✅ - Money rounding? - equals() ✅ - Equal null - Equal object - 5 CHF * 2 = 10 CHF ✅ - Dollar/Franc duplication 👈🏼 - Common `.equals` ✅ - Common `.times` ✅ - Compare Francs with Dollars ✅ - Currency? ✅ - Merge multiplication tests?
Configuration menu - View commit details
-
Copy full SHA for 1678aaa - Browse repository at this point
Copy the full SHA 1678aaaView commit details -
remove unused Franc import in Money test
Tasklist: - $5 + 10CHF = $10 if rate is 2:1 🎯 - $5 * 2 = $10 ✅ - Make "amount" private ✅ - Dollar side-effects? ✅ - Money rounding? - equals() ✅ - Equal null - Equal object - 5 CHF * 2 = 10 CHF ✅ - Dollar/Franc duplication 👈🏼 - Common `.equals` ✅ - Common `.times` ✅ - Compare Francs with Dollars ✅ - Currency? ✅ - Merge multiplication tests?
Configuration menu - View commit details
-
Copy full SHA for f9d36b7 - Browse repository at this point
Copy the full SHA f9d36b7View commit details -
remove Dollar and Franc subclasses
Tasklist: - $5 + 10CHF = $10 if rate is 2:1 🎯 - $5 * 2 = $10 ✅ - Make "amount" private ✅ - Dollar side-effects? ✅ - Money rounding? - equals() ✅ - Equal null - Equal object - 5 CHF * 2 = 10 CHF ✅ - Dollar/Franc duplication ✅ - Common `.equals` ✅ - Common `.times` ✅ - Compare Francs with Dollars ✅ - Currency? ✅ - Merge multiplication tests?
Configuration menu - View commit details
-
Copy full SHA for f446320 - Browse repository at this point
Copy the full SHA f446320View commit details -
delete Franc tests and merge Dollar tests into Money tests
Tasklist: - $5 + 10CHF = $10 if rate is 2:1 🎯 - $5 * 2 = $10 ✅ - Make "amount" private ✅ - Dollar side-effects? ✅ - Money rounding? - equals() ✅ - Equal null - Equal object - 5 CHF * 2 = 10 CHF ✅ - Dollar/Franc duplication ✅ - Common `.equals` ✅ - Common `.times` ✅ - Compare Francs with Dollars ✅ - Currency? ✅ - Merge multiplication tests? ✅
Configuration menu - View commit details
-
Copy full SHA for 8bc4230 - Browse repository at this point
Copy the full SHA 8bc4230View commit details