Add support to sum mixed currencies #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Task list: - $5 + 10CHF = $10 if rate is 2:1 🎯 👈🏼 - $5 + $5 = $10 ✅ - Return Money from $5 + $5 - Bank.reduce(Money) ✅ - Reduce Money with conversion ✅ - Reduce(Bank, String) ✅
kaiosilveira
force-pushed
the
chapter15/sum-mixed-currencies
branch
from
6076246
to
d6ebef8
Compare
Task list: - $5 + 10CHF = $10 if rate is 2:1 🎯 ✅ 🎉 ✨ - $5 + $5 = $10 ✅ - Return Money from $5 + $5 - Bank.reduce(Money) ✅ - Reduce Money with conversion ✅ - Reduce(Bank, String) ✅
Task list: - $5 + 10CHF = $10 if rate is 2:1 🎯 ✅ 🎉 ✨ - $5 + $5 = $10 ✅ - Return Money from $5 + $5 - Bank.reduce(Money) ✅ - Reduce Money with conversion ✅ - Reduce(Bank, String) ✅
Task list: - $5 + 10CHF = $10 if rate is 2:1 🎯 ✅ 🎉 ✨ - $5 + $5 = $10 ✅ - Return Money from $5 + $5 - Bank.reduce(Money) ✅ - Reduce Money with conversion ✅ - Reduce(Bank, String) ✅
Task list: - $5 + 10CHF = $10 if rate is 2:1 🎯 ✅ 🎉 ✨ - $5 + $5 = $10 ✅ - Return Money from $5 + $5 - Bank.reduce(Money) ✅ - Reduce Money with conversion ✅ - Reduce(Bank, String) ✅ - Sum.plus - Expression.times
kaiosilveira
force-pushed
the
chapter15/sum-mixed-currencies
branch
from
d6ebef8
to
3411c92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to our previous work, to implement a multi-currency addition we just need to update the
Sumclass to reduce its members. That's what this PR does. With this, our goal is finally reached!Task list:
Bank.reduce(Money)✅Reduce(Bank, String)✅Sum.plusExpression.times