Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dollar side effects #2

Merged
merged 4 commits into from
Sep 28, 2022
Merged

Fix dollar side effects #2

merged 4 commits into from
Sep 28, 2022

Commits on Sep 28, 2022

  1. add test to triangulate side effect in Dollar.amount 

    Tasklist:
- $5 + 10CHF = $10 if rate is 2:1 🎯
- $5 * 2 = $10 ✅
- Make "amount" private
- Dollar side-effects? 👈🏼
- Money rounding?
    @kaiosilveira
    kaiosilveira committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    a3d6b0e View commit details
    Browse the repository at this point in the history

  2. update test to receive a Dollar as the result of Dollar.times 

    Tasklist:
- $5 + 10CHF = $10 if rate is 2:1 🎯
- $5 * 2 = $10 ✅
- Make "amount" private
- Dollar side-effects? 👈🏼
- Money rounding?
    @kaiosilveira
    kaiosilveira committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    404e6ec View commit details
    Browse the repository at this point in the history

  3. start returning a new Dollar instance after a multiplication 

    Tasklist:
- $5 + 10CHF = $10 if rate is 2:1 🎯
- $5 * 2 = $10 ✅
- Make "amount" private
- Dollar side-effects? 👈🏼
- Money rounding?
    @kaiosilveira
    kaiosilveira committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    81f804f View commit details
    Browse the repository at this point in the history

  4. fix simple multiplication test 

    Tasklist:
- $5 + 10CHF = $10 if rate is 2:1 🎯
- $5 * 2 = $10 ✅
- Make "amount" private
- Dollar side-effects? ✅
- Money rounding?
    @kaiosilveira
    kaiosilveira committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    5878312 View commit details
    Browse the repository at this point in the history