Implement equality for Dollar #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tasklist: - $5 + 10CHF = $10 if rate is 2:1 🎯 - $5 * 2 = $10 ✅ - Make "amount" private - Dollar side-effects? ✅ - Money rounding? - equals() 👈🏼
Tasklist: - $5 + 10CHF = $10 if rate is 2:1 🎯 - $5 * 2 = $10 ✅ - Make "amount" private - Dollar side-effects? ✅ - Money rounding? - equals() 👈🏼
Tasklist: - $5 + 10CHF = $10 if rate is 2:1 🎯 - $5 * 2 = $10 ✅ - Make "amount" private - Dollar side-effects? ✅ - Money rounding? - equals() ✅ - Equal null - Equal object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As our code is written in Typescript instead of Java, equality works a bit different. There's no
equalsmethod to override in subclasses, so what I've done here was actually implementing aequalsmethod that receives adollarobject and casts it to aDollar, finally comparing their amounts to see if there's a match. The function satisfies the equality logic approached by the book and brings, in the same way, two new concerns to our task list: checking equality when the input is null and when the input is another object. Our current tasklist is: