-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplication between Dollar and Franc #6
Commits on Sep 28, 2022
-
Tasklist: - $5 + 10CHF = $10 if rate is 2:1 🎯 - $5 * 2 = $10 ✅ - Make "amount" private ✅ - Dollar side-effects? ✅ - Money rounding? - equals() ✅ - Equal null - Equal object - 5 CHF * 2 = 10 CHF ✅ - Dollar/Franc duplication - Common `.equals` 👈🏼 - Common `.times`
Configuration menu - View commit details
-
Copy full SHA for 1a36772 - Browse repository at this point
Copy the full SHA 1a36772View commit details -
Tasklist: - $5 + 10CHF = $10 if rate is 2:1 🎯 - $5 * 2 = $10 ✅ - Make "amount" private ✅ - Dollar side-effects? ✅ - Money rounding? - equals() ✅ - Equal null - Equal object - 5 CHF * 2 = 10 CHF ✅ - Dollar/Franc duplication - Common `.equals` 👈🏼 - Common `.times`
Configuration menu - View commit details
-
Copy full SHA for 9bdb3a2 - Browse repository at this point
Copy the full SHA 9bdb3a2View commit details -
Tasklist: - $5 + 10CHF = $10 if rate is 2:1 🎯 - $5 * 2 = $10 ✅ - Make "amount" private ✅ - Dollar side-effects? ✅ - Money rounding? - equals() ✅ - Equal null - Equal object - 5 CHF * 2 = 10 CHF ✅ - Dollar/Franc duplication - Common `.equals` 👈🏼 - Common `.times`
Configuration menu - View commit details
-
Copy full SHA for 8a9d0ab - Browse repository at this point
Copy the full SHA 8a9d0abView commit details -
expose amount through a getter
Tasklist: - $5 + 10CHF = $10 if rate is 2:1 🎯 - $5 * 2 = $10 ✅ - Make "amount" private ✅ - Dollar side-effects? ✅ - Money rounding? - equals() ✅ - Equal null - Equal object - 5 CHF * 2 = 10 CHF ✅ - Dollar/Franc duplication - Common `.equals` 👈🏼 - Common `.times`
Configuration menu - View commit details
-
Copy full SHA for 24fe5ac - Browse repository at this point
Copy the full SHA 24fe5acView commit details -
change Dollar to convert the other item in the comparison to a Money
Tasklist: - $5 + 10CHF = $10 if rate is 2:1 🎯 - $5 * 2 = $10 ✅ - Make "amount" private ✅ - Dollar side-effects? ✅ - Money rounding? - equals() ✅ - Equal null - Equal object - 5 CHF * 2 = 10 CHF ✅ - Dollar/Franc duplication - Common `.equals` 👈🏼 - Common `.times`
Configuration menu - View commit details
-
Copy full SHA for 0f0e59c - Browse repository at this point
Copy the full SHA 0f0e59cView commit details -
pull up equals from Dollar to Money
Tasklist: - $5 + 10CHF = $10 if rate is 2:1 🎯 - $5 * 2 = $10 ✅ - Make "amount" private ✅ - Dollar side-effects? ✅ - Money rounding? - equals() ✅ - Equal null - Equal object - 5 CHF * 2 = 10 CHF ✅ - Dollar/Franc duplication - Common `.equals` 👈🏼 - Common `.times`
Configuration menu - View commit details
-
Copy full SHA for b69f0bb - Browse repository at this point
Copy the full SHA b69f0bbView commit details -
add equality test for Dollar in Franc tests
Tasklist: - $5 + 10CHF = $10 if rate is 2:1 🎯 - $5 * 2 = $10 ✅ - Make "amount" private ✅ - Dollar side-effects? ✅ - Money rounding? - equals() ✅ - Equal null - Equal object - 5 CHF * 2 = 10 CHF ✅ - Dollar/Franc duplication - Common `.equals` 👈🏼 - Common `.times`
Configuration menu - View commit details
-
Copy full SHA for 877f22d - Browse repository at this point
Copy the full SHA 877f22dView commit details -
compare Franc.amount to Money.amount at Franc.equals
Tasklist: - $5 + 10CHF = $10 if rate is 2:1 🎯 - $5 * 2 = $10 ✅ - Make "amount" private ✅ - Dollar side-effects? ✅ - Money rounding? - equals() ✅ - Equal null - Equal object - 5 CHF * 2 = 10 CHF ✅ - Dollar/Franc duplication - Common `.equals` 👈🏼 - Common `.times`
Configuration menu - View commit details
-
Copy full SHA for e97643e - Browse repository at this point
Copy the full SHA e97643eView commit details -
make Franc a subclass of Money
Tasklist: - $5 + 10CHF = $10 if rate is 2:1 🎯 - $5 * 2 = $10 ✅ - Make "amount" private ✅ - Dollar side-effects? ✅ - Money rounding? - equals() ✅ - Equal null - Equal object - 5 CHF * 2 = 10 CHF ✅ - Dollar/Franc duplication - Common `.equals` ✅ - Common `.times` - Compare Francs with Dollars
Configuration menu - View commit details
-
Copy full SHA for 6a263ca - Browse repository at this point
Copy the full SHA 6a263caView commit details