Introduce factory methods for franc and dollar #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tasklist: - $5 + 10CHF = $10 if rate is 2:1 🎯 - $5 * 2 = $10 ✅ - Make "amount" private ✅ - Dollar side-effects? ✅ - Money rounding? - equals() ✅ - Equal null - Equal object - 5 CHF * 2 = 10 CHF ✅ - Dollar/Franc duplication - Common `.equals` ✅ - Common `.times` 👈🏼 - Compare Francs with Dollars ✅ - Currency?
…d circular dependencies Tasklist: - $5 + 10CHF = $10 if rate is 2:1 🎯 - $5 * 2 = $10 ✅ - Make "amount" private ✅ - Dollar side-effects? ✅ - Money rounding? - equals() ✅ - Equal null - Equal object - 5 CHF * 2 = 10 CHF ✅ - Dollar/Franc duplication - Common `.equals` ✅ - Common `.times` 👈🏼 - Compare Francs with Dollars ✅ - Currency?
Tasklist: - $5 + 10CHF = $10 if rate is 2:1 🎯 - $5 * 2 = $10 ✅ - Make "amount" private ✅ - Dollar side-effects? ✅ - Money rounding? - equals() ✅ - Equal null - Equal object - 5 CHF * 2 = 10 CHF ✅ - Dollar/Franc duplication - Common `.equals` ✅ - Common `.times` 👈🏼 - Compare Francs with Dollars ✅ - Currency?
… test files Tasklist: - $5 + 10CHF = $10 if rate is 2:1 🎯 - $5 * 2 = $10 ✅ - Make "amount" private ✅ - Dollar side-effects? ✅ - Money rounding? - equals() ✅ - Equal null - Equal object - 5 CHF * 2 = 10 CHF ✅ - Dollar/Franc duplication - Common `.equals` ✅ - Common `.times` 👈🏼 - Compare Francs with Dollars ✅ - Currency?
Tasklist: - $5 + 10CHF = $10 if rate is 2:1 🎯 - $5 * 2 = $10 ✅ - Make "amount" private ✅ - Dollar side-effects? ✅ - Money rounding? - equals() ✅ - Equal null - Equal object - 5 CHF * 2 = 10 CHF ✅ - Dollar/Franc duplication - Common `.equals` ✅ - Common `.times` 👈🏼 - Compare Francs with Dollars ✅ - Currency? - Merge multiplication tests?
kaiosilveira
deleted the
chapter8/introduce-factory-methods-for-franc-and-dollar
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We still have a lot of duplication between
FrancandDollar. This PR implements an intermediary step to address this problem by introducing the factory methodsMoney.dollarandMoney.francand updating the tests accordingly. Our main goal now is to get rid of these two classes and merge their behaviours intoMoney. Our task list is:Tasklist:
.equals✅.times👈🏼