-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement currency #9
Commits on Sep 28, 2022
-
add test to assert for currency
Tasklist: - $5 + 10CHF = $10 if rate is 2:1 🎯 - $5 * 2 = $10 ✅ - Make "amount" private ✅ - Dollar side-effects? ✅ - Money rounding? - equals() ✅ - Equal null - Equal object - 5 CHF * 2 = 10 CHF ✅ - Dollar/Franc duplication - Common `.equals` ✅ - Common `.times` - Compare Francs with Dollars ✅ - Currency? 👈🏼 - Merge multiplication tests?
Configuration menu - View commit details
-
Copy full SHA for 571b98e - Browse repository at this point
Copy the full SHA 571b98eView commit details -
add abstract currency method to Money and implementations for Dollar …
…and Franc Tasklist: - $5 + 10CHF = $10 if rate is 2:1 🎯 - $5 * 2 = $10 ✅ - Make "amount" private ✅ - Dollar side-effects? ✅ - Money rounding? - equals() ✅ - Equal null - Equal object - 5 CHF * 2 = 10 CHF ✅ - Dollar/Franc duplication - Common `.equals` ✅ - Common `.times` - Compare Francs with Dollars ✅ - Currency? 👈🏼 - Merge multiplication tests?
Configuration menu - View commit details
-
Copy full SHA for 0e7c275 - Browse repository at this point
Copy the full SHA 0e7c275View commit details -
add currency as a instance variable in Franc
Tasklist: - $5 + 10CHF = $10 if rate is 2:1 🎯 - $5 * 2 = $10 ✅ - Make "amount" private ✅ - Dollar side-effects? ✅ - Money rounding? - equals() ✅ - Equal null - Equal object - 5 CHF * 2 = 10 CHF ✅ - Dollar/Franc duplication - Common `.equals` ✅ - Common `.times` - Compare Francs with Dollars ✅ - Currency? 👈🏼 - Merge multiplication tests?
Configuration menu - View commit details
-
Copy full SHA for 1563572 - Browse repository at this point
Copy the full SHA 1563572View commit details -
add currency as a instance variable of Dollar
Tasklist: - $5 + 10CHF = $10 if rate is 2:1 🎯 - $5 * 2 = $10 ✅ - Make "amount" private ✅ - Dollar side-effects? ✅ - Money rounding? - equals() ✅ - Equal null - Equal object - 5 CHF * 2 = 10 CHF ✅ - Dollar/Franc duplication - Common `.equals` ✅ - Common `.times` - Compare Francs with Dollars ✅ - Currency? 👈🏼 - Merge multiplication tests?
Configuration menu - View commit details
-
Copy full SHA for a31298a - Browse repository at this point
Copy the full SHA a31298aView commit details -
introduce currency argument to Franc's constructor
Tasklist: - $5 + 10CHF = $10 if rate is 2:1 🎯 - $5 * 2 = $10 ✅ - Make "amount" private ✅ - Dollar side-effects? ✅ - Money rounding? - equals() ✅ - Equal null - Equal object - 5 CHF * 2 = 10 CHF ✅ - Dollar/Franc duplication - Common `.equals` ✅ - Common `.times` - Compare Francs with Dollars ✅ - Currency? 👈🏼 - Merge multiplication tests?
Configuration menu - View commit details
-
Copy full SHA for 5c3586a - Browse repository at this point
Copy the full SHA 5c3586aView commit details -
change Franc.times to use Money.franc factory method
Tasklist: - $5 + 10CHF = $10 if rate is 2:1 🎯 - $5 * 2 = $10 ✅ - Make "amount" private ✅ - Dollar side-effects? ✅ - Money rounding? - equals() ✅ - Equal null - Equal object - 5 CHF * 2 = 10 CHF ✅ - Dollar/Franc duplication - Common `.equals` ✅ - Common `.times` - Compare Francs with Dollars ✅ - Currency? 👈🏼 - Merge multiplication tests?
Configuration menu - View commit details
-
Copy full SHA for f8357cc - Browse repository at this point
Copy the full SHA f8357ccView commit details -
pass CHF as an argument for currency in Money.franc
Tasklist: - $5 + 10CHF = $10 if rate is 2:1 🎯 - $5 * 2 = $10 ✅ - Make "amount" private ✅ - Dollar side-effects? ✅ - Money rounding? - equals() ✅ - Equal null - Equal object - 5 CHF * 2 = 10 CHF ✅ - Dollar/Franc duplication - Common `.equals` ✅ - Common `.times` - Compare Francs with Dollars ✅ - Currency? 👈🏼 - Merge multiplication tests?
Configuration menu - View commit details
-
Copy full SHA for 949a278 - Browse repository at this point
Copy the full SHA 949a278View commit details -
use constructor argument currency in Franc
Tasklist: - $5 + 10CHF = $10 if rate is 2:1 🎯 - $5 * 2 = $10 ✅ - Make "amount" private ✅ - Dollar side-effects? ✅ - Money rounding? - equals() ✅ - Equal null - Equal object - 5 CHF * 2 = 10 CHF ✅ - Dollar/Franc duplication - Common `.equals` ✅ - Common `.times` - Compare Francs with Dollars ✅ - Currency? 👈🏼 - Merge multiplication tests?
Configuration menu - View commit details
-
Copy full SHA for 3764158 - Browse repository at this point
Copy the full SHA 3764158View commit details -
update dollar equality tests to use Money.dollar factory method
Tasklist: - $5 + 10CHF = $10 if rate is 2:1 🎯 - $5 * 2 = $10 ✅ - Make "amount" private ✅ - Dollar side-effects? ✅ - Money rounding? - equals() ✅ - Equal null - Equal object - 5 CHF * 2 = 10 CHF ✅ - Dollar/Franc duplication - Common `.equals` ✅ - Common `.times` - Compare Francs with Dollars ✅ - Currency? 👈🏼 - Merge multiplication tests?
Configuration menu - View commit details
-
Copy full SHA for 31bd733 - Browse repository at this point
Copy the full SHA 31bd733View commit details -
update Dollar to receive currency as a constructor argument
Tasklist: - $5 + 10CHF = $10 if rate is 2:1 🎯 - $5 * 2 = $10 ✅ - Make "amount" private ✅ - Dollar side-effects? ✅ - Money rounding? - equals() ✅ - Equal null - Equal object - 5 CHF * 2 = 10 CHF ✅ - Dollar/Franc duplication - Common `.equals` ✅ - Common `.times` - Compare Francs with Dollars ✅ - Currency? 👈🏼 - Merge multiplication tests?
Configuration menu - View commit details
-
Copy full SHA for 86483e7 - Browse repository at this point
Copy the full SHA 86483e7View commit details -
pull up constructor for Dollar and Franc into Money
Tasklist: - $5 + 10CHF = $10 if rate is 2:1 🎯 - $5 * 2 = $10 ✅ - Make "amount" private ✅ - Dollar side-effects? ✅ - Money rounding? - equals() ✅ - Equal null - Equal object - 5 CHF * 2 = 10 CHF ✅ - Dollar/Franc duplication - Common `.equals` ✅ - Common `.times` - Compare Francs with Dollars ✅ - Currency? ✅ - Merge multiplication tests?
Configuration menu - View commit details
-
Copy full SHA for 2bdf8b7 - Browse repository at this point
Copy the full SHA 2bdf8b7View commit details -
Tasklist: - $5 + 10CHF = $10 if rate is 2:1 🎯 - $5 * 2 = $10 ✅ - Make "amount" private ✅ - Dollar side-effects? ✅ - Money rounding? - equals() ✅ - Equal null - Equal object - 5 CHF * 2 = 10 CHF ✅ - Dollar/Franc duplication - Common `.equals` ✅ - Common `.times` - Compare Francs with Dollars ✅ - Currency? ✅ - Merge multiplication tests?
Configuration menu - View commit details
-
Copy full SHA for 72966f9 - Browse repository at this point
Copy the full SHA 72966f9View commit details