Invoke tearDown() even if test fails
#21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checklist: - run tearDown even if the test fails 👈🏼 --- Output: ➜ python3 src/test_case_test.py 7 run, 1 failed
Checklist: - run tearDown even if the test fails ✅ --- Output: ➜ python3 src/test_case_test.py 7 run, 0 failed
kaiosilveira
changed the title
tearDown() even if test failstearDown() even if test fails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bonus: make sure
tearDown()is called even if the test failsOur goal in this PR was to make sure
tearDown()is being called even if the test executed has failed. This behavior was actually already in place, so a test was added to make sure it remains working and a log entry was added to the call log so we can inspect the data in the correct order.Closes #18