Implement tearDown()
#8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This field will be used to make sure the tests ran in a specific order (specially setUp and tearDown). Checklist: - Invoke tearDown afterward 🎯 - Invoke tearDown even if the test method fails - Run multiple tests - Report collected results - Log string in WasRun 👈🏼
kaiosilveira
force-pushed
the
chapter20/cleaning-up-after
branch
from
2809ec3
to
0cd0596
Compare
Checklist: - Invoke tearDown afterward 🎯 - Invoke tearDown even if the test method fails - Run multiple tests - Report collected results - Log string in WasRun 👈🏼
Checklist: - Invoke tearDown afterward 🎯 - Invoke tearDown even if the test method fails - Run multiple tests - Report collected results - Log string in WasRun 👈🏼
Checklist:
- Invoke tearDown afterward 🎯
- Invoke tearDown even if the test method fails
- Run multiple tests
- Report collected results
- Log string in WasRun 👈🏼
---
Output:
➜ python3 src/test_case_test.py
Traceback (most recent call last):
File "tdd-xunit-example/src/test_case_test.py", line 19, in <module>
TestCaseTest("testSetup").run()
File "tdd-xunit-example/src/test_case.py", line 12, in run
method()
File "tdd-xunit-example/src/test_case_test.py", line 15, in testSetup
assert ("setUp " == self.test.log)
^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError
Checklist: - Invoke tearDown afterward 🎯 - Invoke tearDown even if the test method fails - Run multiple tests - Report collected results - Log string in WasRun 👈🏼
Checklist: - Invoke tearDown afterward 🎯 - Invoke tearDown even if the test method fails - Run multiple tests - Report collected results - Log string in WasRun 👈🏼
Checklist: - Invoke tearDown afterward 🎯 - Invoke tearDown even if the test method fails - Run multiple tests - Report collected results - Log string in WasRun 👈🏼
We are now using it only to configure WasRun, which is in use only in one place, so it's better to just get rid of this extra boilerplate. Checklist: - Invoke tearDown afterward 🎯 - Invoke tearDown even if the test method fails - Run multiple tests - Report collected results - Log string in WasRun ✅
kaiosilveira
force-pushed
the
chapter20/cleaning-up-after
branch
from
0cd0596
to
5b336cd
Compare
Checklist:
- Invoke tearDown afterward 👈🏼🎯
- Invoke tearDown even if the test method fails
- Run multiple tests
- Report collected results
- Log string in WasRun ✅
---
Output:
➜ python3 src/test_case_test.py
Traceback (most recent call last):
File "tdd-xunit-example/src/test_case_test.py", line 12, in <module>
TestCaseTest("testTemplateMethod").run()
File "tdd-xunit-example/src/test_case.py", line 12, in run
method()
File "tdd-xunit-example/src/test_case_test.py", line 9, in testTemplateMethod
assert ("setUp testMethod tearDown " == test.log)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError
Checklist:
- Invoke tearDown afterward 👈🏼🎯
- Invoke tearDown even if the test method fails
- Run multiple tests
- Report collected results
- Log string in WasRun ✅
---
Output:
➜ python3 src/test_case_test.py
Traceback (most recent call last):
File "tdd-xunit-example/src/test_case_test.py", line 12, in <module>
TestCaseTest("testTemplateMethod").run()
File "tdd-xunit-example/src/test_case.py", line 13, in run
self.tearDown()
^^^^^^^^^^^^^
AttributeError: 'TestCaseTest' object has no attribute 'tearDown'
Checklist: - Invoke tearDown afterward ✅ - Invoke tearDown even if the test method fails - Run multiple tests - Report collected results - Log string in WasRun ✅
kaiosilveira
force-pushed
the
chapter20/cleaning-up-after
branch
from
5b336cd
to
bdc22b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chapter 20: Cleaning up after
Our goal in this chapter was to implement some form of clean-up mechanism so our tests always start from a clean slate. Our approach here was to introduce a
tearDown()method to be called after the test method was run.Implementation checklist:
✅
Invoke tearDown afterward☑️ Invoke tearDown even if the test method fails
☑️ Run multiple tests
☑️ Report collected results
✅
Log string in WasRunCloses #6