Detect version correctly so that we also push "latest" tag #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
jimmykarily
commented
Nov 15, 2024
| @@ -32,7 +32,7 @@ jobs: | |||
| # If the VERSION looks like a version number, assume that | |||
| # this is the most recent version of the image and also | |||
| # tag it 'latest'. | |||
| if [[ $VERSION =~ ^[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}$ ]]; then | |||
| if [[ $VERSION =~ ^v[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}$ ]]; then | |||
There was a problem hiding this comment.
because v is part of what git describe returns:
~/workspace/kairos/AuroraBoot (also-push-latest)*$ git describe --always --tags --dirty
v0.3.2-1-g2fea056
|
I think master is whats pushed to latest by default |
Itxaka
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something was pushed as
latestbut not the tagged image. Not sure what: