Create directories with 755 permissions #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because otherwise the rootfs `/` has permissions 755 which results in all users except "root" to not be able to login or run any commands Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Itxaka
reviewed
Dec 4, 2024
| @@ -72,7 +72,7 @@ func TempDir(fs v1.FS, dir, prefix string) (name string, err error) { | |||
| } | |||
| // This skips adding random stuff to the created temp dir so the temp dir created is predictable for testing | |||
| if _, isTestFs := fs.(*vfst.TestFS); isTestFs { | |||
| err = MkdirAll(fs, filepath.Join(dir, prefix), 0700) | |||
| err = MkdirAll(fs, filepath.Join(dir, prefix), 0755) | |||
There was a problem hiding this comment.
I think this one is not necessary as it's only for testing IIRC
There was a problem hiding this comment.
but doesn't hurt either, right? Better be consistent.
Itxaka
approved these changes
Dec 4, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #129 +/- ##
=======================================
Coverage 15.48% 15.48%
=======================================
Files 10 10
Lines 1614 1614
=======================================
Hits 250 250
Misses 1348 1348
Partials 16 16 ☔ View full report in Codecov by Sentry. |
Itxaka
reviewed
Dec 4, 2024
| @@ -12,22 +12,22 @@ import ( | |||
| func (d *Deployer) StepPrepNetbootDir() error { | |||
| return d.Add(opPrepareNetboot, herd.WithCallback( | |||
| func(ctx context.Context) error { | |||
| return os.MkdirAll(d.dstNetboot(), 0700) | |||
| return os.MkdirAll(d.dstNetboot(), 0755) | |||
There was a problem hiding this comment.
we should probably use a constant for this as we do on other places, but lets fix it first
jimmykarily
added a commit
to kairos-io/kairos
that referenced
this pull request
Dec 4, 2024
kairos-io/AuroraBoot#129 without this, the isos we generate will not allow any non-root user to login after installation Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
jimmykarily
added a commit
to kairos-io/kairos
that referenced
this pull request
Dec 5, 2024
kairos-io/AuroraBoot#129 without this, the isos we generate will not allow any non-root user to login after installation Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because otherwise the rootfs
/has permissions 755 which results in all users except "root" to not be able to login or run any commands