Fail out if cc was specified but contents are empty #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So we can cache most of the stuff fi its being rebuilt Signed-off-by: Itxaka <itxaka@kairos.io>
If we have marked a cloud config file but after parsing and templating, the contents are empty, error out as it points out to a user error on choosing the file. If no cc is set, the check wont fail out. Signed-off-by: Itxaka <itxaka@kairos.io>
Signed-off-by: Itxaka <itxaka@kairos.io>
jimmykarily
reviewed
Oct 2, 2024
jimmykarily
approved these changes
Oct 2, 2024
mauromorales
approved these changes
Oct 2, 2024
jimmykarily
approved these changes
Oct 2, 2024
Itxaka
force-pushed
the
copy_file_debug
branch
2 times, most recently
from
c9bd215 to
d6dd93b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we have marked a cloud config file but after parsing and templating,
the contents are empty, error out as it points out to a user error on
choosing the file.
If no cc is set, the check wont fail out.
This also brings some small improvements to dockerfile to not have to fully rebuild the dockerfile each time something is changed on aurora for testing
Probably fixes kairos-io/kairos#2876 as it looks like a wrong naming issue can lead to confusion like this. With this patch, the error will be immediately evident
Signed-off-by: Itxaka itxaka@kairos.io