Introduce "convert" command #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmykarily
force-pushed
the
1721-enki-convert-image
branch
from
2b57e3e
to
b44c437
Compare
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
so that we can generate a dockerfile without building the image. This makes it more testable and also allows us to handle the building step differently depending on whether we are inside Kubernetes or buildling locally. Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
jimmykarily
force-pushed
the
1721-enki-convert-image
branch
from
7a64d60
to
0ee6ef6
Compare
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
TODO: Implement `enki find-matching-framework` command in main and release a new enki version with it, so that we can consume it in Dockerfiles. Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Let's keep things simple for now. Trying to figure out the right framework image automatically will be very error prone. By making it a manual setting, we allow the user to even set it to a custom image or use one that they know it works. Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
It's not working as it is because we need to install systemd which is part of the Kairos dockerfiles Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
to test that the generate dockerfiles are buildable and do what they are supposed to do. Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
|
Closing in favor of: kairos-io/kairos#1898 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: kairos-io/kairos#1721