Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

try to decode pkcs1 and 8 formats #11

Merged
merged 1 commit into from
Jun 25, 2024
Merged

try to decode pkcs1 and 8 formats #11

merged 1 commit into from
Jun 25, 2024

Conversation

Itxaka
Copy link
Member

@Itxaka Itxaka commented Jun 25, 2024 •
edited
Loading

In case we get a different format private key, try to decode both formats before failing

@Itxaka
try to decode pkcs1 and 8 formats
93b8c83 
Signed-off-by: Itxaka <itxaka@kairos.io>
@Itxaka Itxaka requested a review from a team June 25, 2024 08:05
mudler
mudler approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@mudler mudler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Itxaka Itxaka merged commit 3aca971 into main Jun 25, 2024
4 checks passed
@Itxaka Itxaka deleted the extra_key branch June 25, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mudler mudler mudler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Itxaka @mudler