Fix partitioner not identifying mmc/nvme partitions #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were expecting them to follow us the device name + numer at the end but mmc and nvme partitions follow a different schema. In order to make this work for anything and even new schemas that we may not expect, we just get the actual device directly from udev by resolving the /dev/disk/by-partlabel which links to the actual named device. Signed-off-by: Itxaka <itxaka@kairos.io>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #563 +/- ##
==========================================
+ Coverage 49.70% 49.73% +0.03%
==========================================
Files 48 48
Lines 4585 4588 +3
==========================================
+ Hits 2279 2282 +3
Misses 2029 2029
Partials 277 277 ☔ View full report in Codecov by Sentry. |
jimmykarily
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were expecting them to follow us the device name + numer at the end but mmc and nvme partitions follow a different schema.
In order to make this work for anything and even new schemas that we may not expect, we just get the actual device directly from udev by resolving the /dev/disk/by-partlabel which links to the actual named device.