Fix reset

[Itxaka]

Seems like witht he older ghw, we were not receiving all the proper partitions and mountpoints and such, so on reset we could blindily try to unmount all partitions and call it a day.

But now we get info about all of them, so doing so will even unmount the current recovery partition, where the reset source is at, thus failing the reset copy.

This patch fixes it by instead of going crazy, making sure we have an order mount/unmount of the proper places at the proper times and we restore everything as is once we are done with it

[jimmykarily]

These errors would have helped us fixing it. Can we print those errors too?

diff --git a/pkg/utils/common.go b/pkg/utils/common.go
index abc11b5..9262fcb 100644
--- a/pkg/utils/common.go
+++ b/pkg/utils/common.go
@@ -106,14 +106,17 @@ func ConcatFiles(fs v1.FS, sources []string, target string) (err error) {
        for _, source := range sources {
                sourceFile, err := fs.Open(source)
                if err != nil {
+                       fmt.Printf("err.Error() = %+v\n", err.Error())
                        break
                }
                _, err = io.Copy(targetFile, sourceFile)
                if err != nil {
+                       fmt.Printf("err.Error() = %+v\n", err.Error())
                        break
                }
                err = sourceFile.Close()
                if err != nil {
+                       fmt.Printf("err.Error() = %+v\n", err.Error())
                        break
                }
        }

using some logger preferably

[jimmykarily]

These errors would have helped us fixing it. Can we print those errors too?

diff --git a/pkg/utils/common.go b/pkg/utils/common.go
index abc11b5..9262fcb 100644
--- a/pkg/utils/common.go
+++ b/pkg/utils/common.go
@@ -106,14 +106,17 @@ func ConcatFiles(fs v1.FS, sources []string, target string) (err error) {
        for _, source := range sources {
                sourceFile, err := fs.Open(source)
                if err != nil {
+                       fmt.Printf("err.Error() = %+v\n", err.Error())
                        break
                }
                _, err = io.Copy(targetFile, sourceFile)
                if err != nil {
+                       fmt.Printf("err.Error() = %+v\n", err.Error())
                        break
                }
                err = sourceFile.Close()
                if err != nil {
+                       fmt.Printf("err.Error() = %+v\n", err.Error())
                        break
                }
        }

using some logger preferably

actually, just return the error (wrapped or not).

[Itxaka]

These errors would have helped us fixing it. Can we print those errors too?

diff --git a/pkg/utils/common.go b/pkg/utils/common.go
index abc11b5..9262fcb 100644
--- a/pkg/utils/common.go
+++ b/pkg/utils/common.go
@@ -106,14 +106,17 @@ func ConcatFiles(fs v1.FS, sources []string, target string) (err error) {
        for _, source := range sources {
                sourceFile, err := fs.Open(source)
                if err != nil {
+                       fmt.Printf("err.Error() = %+v\n", err.Error())
                        break
                }
                _, err = io.Copy(targetFile, sourceFile)
                if err != nil {
+                       fmt.Printf("err.Error() = %+v\n", err.Error())
                        break
                }
                err = sourceFile.Close()
                if err != nil {
+                       fmt.Printf("err.Error() = %+v\n", err.Error())
                        break
                }
        }

using some logger preferably

actually, just return the error (wrapped or not).

tbh, I would like to do this in a different PR if possible> As it can introduce new errors and I want this to fix the actual reset issue before breaking it further lol

[codecov]

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 49.80%. Comparing base (84d87b3) to head (efa3762).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
pkg/action/reset.go	75.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #565      +/-   ##
==========================================
+ Coverage   49.73%   49.80%   +0.06%     
==========================================
  Files          48       48              
  Lines        4588     4582       -6     
==========================================
  Hits         2282     2282              
+ Misses       2029     2026       -3     
+ Partials      277      274       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.