Add boot assesment for install and bootentry #604
+149
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Itxaka <itxaka@kairos.io>
|
I need to check upgrade as Its not clear what it does. |
Signed-off-by: Itxaka <itxaka@kairos.io>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #604 +/- ##
==========================================
- Coverage 48.19% 48.05% -0.15%
==========================================
Files 48 48
Lines 6023 6049 +26
==========================================
+ Hits 2903 2907 +4
- Misses 2842 2863 +21
- Partials 278 279 +1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Otherwise it wont match between the file on the system and the selected default value in the loader.conf Signed-off-by: Itxaka <itxaka@kairos.io>
Make it simpler by making it work for both install and upgrade by doing the proper thing: check if conf file have it enabled, if not enable it for the conf file This should work with the install as well Signed-off-by: Itxaka <itxaka@kairos.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of kairos-io/kairos#2864