Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logic should live in the overlay files, not in Earthly #1726

Closed
Tracked by #116
jimmykarily opened this issue Aug 16, 2023 · 1 comment · Fixed by #1738
Closed
Tracked by #116

Logic should live in the overlay files, not in Earthly #1726

jimmykarily opened this issue Aug 16, 2023 · 1 comment · Fixed by #1738
Assignees
@jimmykarily

Comments

@jimmykarily
Copy link
Contributor

jimmykarily commented Aug 16, 2023 •
edited
Loading

The idea is described here: #1721 (comment)

After this story is done, the Earthly file of Kairos should be simplified and it should simply copy all overlay files in place.
@jimmykarily jimmykarily mentioned this issue Aug 16, 2023
Closed
@mudler mudler mentioned this issue Aug 8, 2023
Closed
44 tasks
@jimmykarily
Copy link
Contributor Author

wip branch: https://github.com/kairos-io/kairos/tree/1726-move-logic-to-overlays

@jimmykarily jimmykarily self-assigned this Aug 17, 2023
jimmykarily added a commit to kairos-io/packages that referenced this issue Aug 17, 2023
@jimmykarily
Create kairos-overlay-files package
cbeb472 
as part of: kairos-io/kairos#1726

Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
@jimmykarily jimmykarily mentioned this issue Aug 17, 2023
Merged
jimmykarily added a commit to kairos-io/packages that referenced this issue Aug 17, 2023
@jimmykarily
Create kairos-overlay-files package
9bbd15a 
as part of: kairos-io/kairos#1726

Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
jimmykarily added a commit to kairos-io/packages that referenced this issue Aug 17, 2023
@jimmykarily
Create kairos-overlay-files package
7c6f01e 
as part of: kairos-io/kairos#1726

Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
jimmykarily added a commit to kairos-io/packages that referenced this issue Aug 17, 2023
@jimmykarily
Create kairos-overlay-files package (#381)
98ba6d2 
* Create kairos-overlay-files package

as part of: kairos-io/kairos#1726

Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>

* Start from version 1.0.0 for the new package

Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>

---------

Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
@jimmykarily jimmykarily mentioned this issue Aug 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jimmykarily jimmykarily

Labels
None yet
Projects
🧙Issue tracking board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

1726 move logic to overlays kairos-io/kairos
1 participant
@jimmykarily