🤖 Do not auto reboot on uki tests #2549
Conversation
Signed-off-by: Itxaka <itxaka@kairos.io>
Signed-off-by: Itxaka <itxaka@kairos.io>
| with: | ||
| repository: quay.io/kairos/packages | ||
| packages: system/kairos-agent | ||
| - name: Push to quay |
There was a problem hiding this comment.
I think we still need core because this is what the edge team has been using for their tests, no?
There was a problem hiding this comment.
Core was just the same as the Ubuntu lts no? It's building 24.04? Or did I screwed it up?
There was a problem hiding this comment.
Ohh this pushes it to quay on master!
Good catch, I thought we had that on the reusable job...we may need to have that there anyway?
There was a problem hiding this comment.
No I think we don't have it on the reusable job but I guess we could use the reusable job to build and then still push just on the ones we want to push, since we don't want fedora atm for example
There was a problem hiding this comment.
I added it to the reusable job, now it pushes AFTER tests pass and only if its from master and UBUNTU
I would change that to push always, so any image that we test is pushed....makes sense to me, if we run tests and it passes, we should make that image available no?
There was a problem hiding this comment.
@Itxaka yeah I don't see why not, but we should make sure we also "release" those maybe?
There was a problem hiding this comment.
well, maybe not unless we "support" them somehow rigth?
Its nice to have the images pushed from master so we can test building isos from there and such. But on release, we are committing to it rigth? like we are saying is supported by making it an official release artifact rather than a in-progress dev version. I would be ok with that but our current focus is on ubuntu so not sure if it would make sense to make it officially supported with our bandwidth :(
Something to discuss on Monday I guess?
Signed-off-by: Itxaka <itxaka@kairos.io>
|
Blocked until we can discuss on monday meeting what to do with fedora uki releases |
Itxaka
changed the title
When we run the uki tests, we tail the logs at /var/log/kairos to see if we can find the correct steps.
This is due so we can test the uki install via datasource iso, i.e. the install starts and runs automatically.
By setting the reboot to true, sometimes the machine will reboot while we are still trying to collect the logs and cause an ssh force exit, which breaks the test.
This also makes no sense as in the uki test we reboot automatically after we have checked that the install goes ok.
This patch makes it so the install wont autorestart automatically so we can check all the install steps via logs properly.
It also reworks a bit the uki job to be a matrix and removes the core uki job which was a clone of the uki jobs